Skip to content

Commit

Permalink
[ValueTracking] Use maximum shift count in shl when determining if …
Browse files Browse the repository at this point in the history
…`shl` can be zero.

Previously only return `shl` non-zero if the shift value was `1`. We
can expand this if we have some bounds on the shift count.

For example:
    ```
    %cnt = and %c, 16 ; Max cnt == 16
    %val = or %v, 4 ; val[2] is known one
    %shl = shl %val, %cnt ; (val.known.one << cnt.maxval) != 0
    ```

Differential Revision: https://reviews.llvm.org/D147897
  • Loading branch information
goldsteinn committed Apr 14, 2023
1 parent e7999fb commit 684963b
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 9 deletions.
10 changes: 10 additions & 0 deletions llvm/lib/Analysis/ValueTracking.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2681,6 +2681,16 @@ bool isKnownNonZero(const Value *V, const APInt &DemandedElts, unsigned Depth,
computeKnownBits(I->getOperand(0), DemandedElts, Known, Depth, Q);
if (Known.One[0])
return true;

if (!Known.isUnknown()) {
KnownBits KnownCnt =
computeKnownBits(I->getOperand(1), DemandedElts, Depth, Q);

if (KnownCnt.getMaxValue().ult(Known.getBitWidth()) &&
!Known.One.shl(KnownCnt.getMaxValue()).isZero())
return true;
}

break;
}
case Instruction::LShr:
Expand Down
11 changes: 2 additions & 9 deletions llvm/test/Analysis/ValueTracking/known-non-zero.ll
Original file line number Diff line number Diff line change
Expand Up @@ -170,11 +170,7 @@ define <2 x i1> @check_add_sat_vec(<2 x i8> %x, <2 x i8> %y, <2 x i8> %w) {

define <2 x i1> @shl_nz_bounded_cnt_vec(<2 x i32> %x, <2 x i32> %y) {
; CHECK-LABEL: @shl_nz_bounded_cnt_vec(
; CHECK-NEXT: [[CNT:%.*]] = and <2 x i32> [[X:%.*]], <i32 16, i32 24>
; CHECK-NEXT: [[VAL:%.*]] = or <2 x i32> [[Y:%.*]], <i32 131088, i32 16>
; CHECK-NEXT: [[SHL:%.*]] = shl <2 x i32> [[VAL]], [[CNT]]
; CHECK-NEXT: [[R:%.*]] = icmp eq <2 x i32> [[SHL]], zeroinitializer
; CHECK-NEXT: ret <2 x i1> [[R]]
; CHECK-NEXT: ret <2 x i1> zeroinitializer
;
%cnt = and <2 x i32> %x, <i32 16, i32 24>
%val = or <2 x i32> %y, <i32 131088, i32 16>
Expand All @@ -187,10 +183,7 @@ define i1 @shl_nz_bounded_cnt(i32 %cnt, i32 %y) {
; CHECK-LABEL: @shl_nz_bounded_cnt(
; CHECK-NEXT: [[CNT_ULT4:%.*]] = icmp ult i32 [[CNT:%.*]], 4
; CHECK-NEXT: call void @llvm.assume(i1 [[CNT_ULT4]])
; CHECK-NEXT: [[VAL:%.*]] = or i32 [[Y:%.*]], 131072
; CHECK-NEXT: [[SHL:%.*]] = shl i32 [[VAL]], [[CNT]]
; CHECK-NEXT: [[R:%.*]] = icmp eq i32 [[SHL]], 0
; CHECK-NEXT: ret i1 [[R]]
; CHECK-NEXT: ret i1 false
;
%cnt_ult4 = icmp ult i32 %cnt, 4
call void @llvm.assume(i1 %cnt_ult4)
Expand Down

0 comments on commit 684963b

Please sign in to comment.