Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing #1584

Merged
merged 2 commits into from
May 7, 2018
Merged

Tracing #1584

merged 2 commits into from
May 7, 2018

Conversation

wyattjoh
Copy link
Collaborator

@wyattjoh wyattjoh commented May 7, 2018

What does this PR do?

Include trace ID in each downstream request.

How do I test this PR?

Load the stream, look at the /api/v1/graph/ql request in the network inspector, notice the X-Talk-Trace-ID header that matches the traceID in the logs corresponding to the request.

@wyattjoh wyattjoh added this to the 4.4.0 GDPR Features and Support milestone May 7, 2018
@kgardnr kgardnr self-requested a review May 7, 2018 21:21
Copy link
Contributor

@kgardnr kgardnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing the header in Chrome or FF

@kgardnr kgardnr merged commit 926364a into master May 7, 2018
@kgardnr kgardnr deleted the trace branch May 7, 2018 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants