Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Body Count #1969

Merged
merged 3 commits into from
Oct 5, 2018
Merged

Body Count #1969

merged 3 commits into from
Oct 5, 2018

Conversation

wyattjoh
Copy link
Collaborator

@wyattjoh wyattjoh commented Oct 4, 2018

What does this PR do?

Adjusts the behavior when a comment exceeds the maximum length, preventing it from being committed at all.

How do I test this PR?

  1. In the admin (/admin/configure/stream), ensure that the Limit Comment Length is unchecked, and saved.
  2. In another browser, open the stream (/dev), and login as another user.
  3. Back in the admin browser/tab, check the box for comment length, setting it to 5
  4. In the user tab, submit the comment 123456, and see the error on the stream page indicating the comment length was exceeded.
  5. In the admin tab, notice that the comment does not appear int he moderation screen.

@wyattjoh wyattjoh requested a review from okbel October 5, 2018 17:52
Copy link
Contributor

@okbel okbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👍

@wyattjoh wyattjoh merged commit d0eca26 into master Oct 5, 2018
@wyattjoh wyattjoh deleted the fix/body-count branch October 5, 2018 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants