add tests to settings models/endpoints #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jde
approved these changes
Nov 7, 2016
| .put('/api/v1/settings') | ||
| .send({moderation: 'post'}, (err, res) => { | ||
| expect(err).to.be.null; | ||
| expect(res).to.have.status(204); |
There was a problem hiding this comment.
Would it be safer to return 200 with the settings object in the body? This way a fe could update it's state and ensure that what the user sees exactly reflects what's in the db.
This is a larger style question for our apis. Approving PR.
There was a problem hiding this comment.
that's what I had before, but @wyattjoh pointed out that it's more inline with REST to just return something along the lines of "it worked" instead of returning stuff from a PUT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds test coverage to
Settingmodel and corresponding endpoints.How do I test this PR?
npm test@coralproject/tech