Utilize a different database for testing #224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyattjoh
requested changes
Jan 11, 2017
| // default, this is consistent with common testing and use case practices. | ||
| if (process.env.NODE_ENV === 'test' && !url) { | ||
| if (process.env.NODE_ENV === 'test') { |
There was a problem hiding this comment.
Development should not use the test database. When you start the application, you specify the database to use. When you run tests, you do not load configuration into the environment, as tests would not be predictable if it depended on local configuration. Hence, this change is not necessary, and counter to what is expected if you do override the url.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Recent updates to the database handler cause us to use the same database for testing and for development. This is not a best practice and inconveniently causes the development DB to be cleared every time tests are run. This change ensures that tests are always run in a separate database.
How do I test this PR?
npm test