Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post comment #25

Merged
merged 5 commits into from
Nov 7, 2016
Merged

Post comment #25

merged 5 commits into from
Nov 7, 2016

Conversation

davidgljay
Copy link

@davidgljay davidgljay commented Nov 7, 2016 •
edited
Loading

What does this PR do?

Fixes a bug in comment count, fixes post order.

How do I test this PR?

  1. npm run embed-start
  2. Comment count should include replies.
  3. Comments should appear in chronological order when posted.
  4. Comments should appear in chronological order on page reload.
  5. Pym.js in http://localhost:3000/client/coral-embed-stream/samplearticle.html should serve over https.

@coralproject/tech

gabelula
gabelula approved these changes Nov 7, 2016
View reviewed changes
Copy link

@gabelula gabelula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fine.

@jde jde merged commit 8cc6d9d into master Nov 7, 2016
@jde jde deleted the post-comment branch November 7, 2016 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabelula gabelula gabelula approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidgljay @gabelula @jde