Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions Metadata #297

Merged
merged 7 commits into from
Feb 10, 2017
Merged

Actions Metadata #297

merged 7 commits into from
Feb 10, 2017

Conversation

wyattjoh
Copy link
Collaborator

@wyattjoh wyattjoh commented Feb 9, 2017

What does this PR do?

How do I test this PR?

Test the following out in GraphiQL:

fragment flagActionSummaryView on FlagActionSummary {
  reason
}

fragment actionSummaryView on ActionSummary {
  __typename
  count
  ...flagActionSummaryView
  current_user {
    id
    created_at
  }
}

fragment commentView on Comment {
  id
  body
  action_summaries {
    ...actionSummaryView
  }
  created_at
}

query LotsOfActions {
  assets {
    comments {
      ...commentView
      replies {
        ...commentView
      }
    }
  }
}

mutation CreateFlag($id: ID!) {
  createFlag(flag: {item_id: $id, item_type: COMMENTS, reason: "Offensive"}) {
    flag {
      id
    }
    errors {
      translation_key
    }
  }
}

Build static assets yarn build (or yarn build-watch) and view the docs page at http://localhost:3000/admin/docs.

@wyattjoh wyattjoh changed the title Actions Actions Remix Feb 9, 2017
@wyattjoh wyattjoh changed the title Actions Remix Actions Metadata Feb 9, 2017
@okbel okbel self-requested a review February 9, 2017 08:45
@davidgljay
Copy link

Frontend is updated and ready for review, nice job @wyattjoh !

@davidgljay
Copy link

Note: I'm not worrying about optimizing the admin panel to display this data since that's all about to get refactored with GraphQL anyway.

@jde
Copy link

jde commented Feb 10, 2017

Tested this. The stream works perfectly.

This creates an issue in the moderation queue where the flagged comment doesn't get removed from the stream when an action is taken. QA approval granted as this issue will be naturally resolved by @okbel in her current work.

@riley
Copy link

riley commented Feb 10, 2017

I had a weird issue where if I liked something, reloaded, and clicked Like again it would unlike it, but if I re-liked it, the likes read Liked 2

@jde
Copy link

jde commented Feb 10, 2017

@riley I see the bug, but it is due to the way that the LikeButton component handles internal state and optimistic updates. I'll move this to an issue as it is out of the scope of this PR.

@jde jde requested review from jde and removed request for okbel February 10, 2017 19:43
@jde jde merged commit 5c4daa7 into master Feb 10, 2017
@jde jde deleted the actions branch February 10, 2017 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants