Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-2147] Track queue sort change events into metrics #3594

Closed
wants to merge 3 commits into from

Conversation

nick-funk
Copy link
Contributor

What does this PR do?

When the user changes the sortedBy in the moderation queues, we fire an event with the eventEmitter that can be collected into our metrics.

What changes to the GraphQL/Database Schema does this PR introduce?

None

How do I test this PR?

  • Start up app
  • Go to mod queues
  • Change sort by back and forth
  • See event emitter logs in the Coral CLI output

@nick-funk nick-funk requested a review from cvle June 23, 2021 19:26
src/core/client/stream/events.ts Outdated Show resolved Hide resolved
Was accidentally created as a network event.
@nick-funk nick-funk force-pushed the feat/CORL-2147-sort-event branch from 638dbe9 to 5291ed0 Compare June 25, 2021 14:36
@nick-funk nick-funk requested a review from cvle June 25, 2021 17:05
Copy link
Member

@cvle cvle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createViewerEvent and createViewerNetworkEvent has a slightly different API, after adapting the code, this PR is good to go!

@nick-funk nick-funk requested a review from cvle June 30, 2021 22:01
Copy link
Member

@cvle cvle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a way to collect metrics on the admin yet.

@nick-funk
Copy link
Contributor Author

Closing this as we don't have metrics Admin side and we don't have a need to remove the sorting. Instead, we need to make the DB handle this gracefully.

@nick-funk nick-funk closed this Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants