Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notifications: update featured notification icon #4561

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

kabeaty
Copy link
Contributor

@kabeaty kabeaty commented Feb 26, 2024

What does this PR do?

Updates the icon for notifications for featured comments.

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

none

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

You can feature a comment and then log in as the commenter whose comment was featured to see the notification for it. You should see the rating star ribbon icon beside this notification.

Were any tests migrated to React Testing Library?

How do we deploy this PR?

@kabeaty kabeaty requested a review from nick-funk February 26, 2024 20:23
Copy link
Contributor

@nick-funk nick-funk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nick-funk nick-funk merged commit 72efb50 into epic/notifications Mar 5, 2024
2 checks passed
@nick-funk nick-funk deleted the notifications/update-featured-icon branch March 5, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants