Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notifications: design and configuration updates #4562

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

kabeaty
Copy link
Contributor

@kabeaty kabeaty commented Feb 26, 2024

What does this PR do?

These changes make some design and configuration updates to notifications.

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

Adds the floatingBellIndicator to inPageNotifications settings.

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

You can test these changes by:

  1. Hover over the sticky corner bell on desktop. See a pointer cursor. Click the bell. Hover over close/bell icon in upper right. See a pointer cursor here too.
  2. View comments in mobile to see the mobile toolbar. See that there is no longer an X option and the rest of the buttons have more space now because of that.
  3. Load comment stream. Go to another tab/window. Go back. See the Refresh comments button. See that it has more padding now.
  4. Go to admin configuration --> General --> In-page notifications. See the new Floating bell indicator option. See that when the overall in-page notifications is disabled, these options are disabled. See that when the in-page notifications are overall enabled, this floating bell indicator option is selectable. Enable it and go to the comment stream. See the notifications tab to the right and the floating bell button in the upper right. Disable it and go to the comment stream. See the notifications tab to the left and no floating bell button in the upper right when scrolling down the comment stream.

Were any tests migrated to React Testing Library?

How do we deploy this PR?

@kabeaty kabeaty requested a review from nick-funk February 26, 2024 20:33
Copy link
Contributor

@nick-funk nick-funk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nick-funk nick-funk merged commit 05d3935 into epic/notifications Mar 5, 2024
1 check passed
@nick-funk nick-funk deleted the notifications/design-updates branch March 5, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants