notifications: design and configuration updates #4562
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These changes make some design and configuration updates to notifications.
These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
Adds the
floatingBellIndicator
toinPageNotifications
settings.Does this PR introduce any new environment variables or feature flags?
no
If any indexes were added, were they added to
INDEXES.md
?n/a
How do I test this PR?
You can test these changes by:
X
option and the rest of the buttons have more space now because of that.Refresh comments
button. See that it has more padding now.General
-->In-page notifications
. See the newFloating bell indicator
option. See that when the overall in-page notifications is disabled, these options are disabled. See that when the in-page notifications are overall enabled, this floating bell indicator option is selectable. Enable it and go to the comment stream. See the notifications tab to the right and the floating bell button in the upper right. Disable it and go to the comment stream. See the notifications tab to the left and no floating bell button in the upper right when scrolling down the comment stream.Were any tests migrated to React Testing Library?
How do we deploy this PR?