Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CORL-3174] Move external mod phases to run before pre-moderation #4641

Merged
merged 2 commits into from
Aug 6, 2024
Merged

[CORL-3174] Move external mod phases to run before pre-moderation #4641

merged 2 commits into from
Aug 6, 2024

Conversation

nick-funk
Copy link
Contributor

What does this PR do?

Makes the external mod phases run before the pre-moderation phases in the moderation pipeline.

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

None

Does this PR introduce any new environment variables or feature flags?

No

If any indexes were added, were they added to INDEXES.md?

N/A

How do I test this PR?

  • Hook up external mod phases in admin to an external endpoint
    • I recommend using utilities/externalModPhase
  • Test that everything works as expected with mod phases connected and running prior to pre-mod steps

Were any tests migrated to React Testing Library?

No

How do we deploy this PR?

  • Merge into develop

@nick-funk nick-funk requested review from tessalt and kabeaty July 4, 2024 16:54
@nick-funk nick-funk changed the title [CORL-3174] Move external mod phases before pre-moderation [CORL-3174] Move external mod phases to run before pre-moderation Jul 4, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 4, 2024 •
edited
Loading

✅ Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit 372ef4d
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/6686d3ccfb1a340008792159

@nick-funk nick-funk mentioned this pull request Jul 4, 2024
Closed
kabeaty
kabeaty approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@kabeaty kabeaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tessalt tessalt added this pull request to the merge queue Aug 6, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 6, 2024
@tessalt
Merge pull request #4641 from coralproject/feat/CORL-3174-external-be…
be295b3 
…fore-premod

[CORL-3174] Move external mod phases to run before pre-moderation
@tessalt tessalt removed this pull request from the merge queue due to a manual request Aug 6, 2024
@tessalt tessalt merged commit 546358a into develop Aug 6, 2024
6 checks passed
@tessalt tessalt deleted the feat/CORL-3174-external-before-premod branch August 6, 2024 15:47
@losowsky losowsky mentioned this pull request Aug 7, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kabeaty kabeaty kabeaty approved these changes

@tessalt tessalt tessalt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nick-funk @tessalt @kabeaty