Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v9.4.0 #4678

Merged
merged 41 commits into from
Oct 3, 2024
Merged

v9.4.0 #4678

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
f1d32c7
remove extra Tab definition
kabeaty Sep 27, 2024
eb5928c
update tests
kabeaty Sep 27, 2024
65e9696
initial update to pause/play gifs in mod queue
kabeaty Sep 30, 2024
400c4c0
rename gifmedia comp; remove tenormedia comp; update commentrevisionc…
kabeaty Sep 30, 2024
325fa3b
fix linting
kabeaty Sep 30, 2024
a648c02
move tenor api types into common; use for tenor fetch payload
kabeaty Sep 30, 2024
554602f
Merge pull request #4667 from coralproject/fix/CORL-3190-error-screen…
tessalt Sep 30, 2024
308712d
update webhooks docs links
kabeaty Sep 30, 2024
6945b13
Merge branch 'develop' into fix/CORL-3180-dont-autoplay-gifs-mod-queue
tessalt Sep 30, 2024
72bb7ab
initial send notification on previously rejected comment being approved
kabeaty Sep 30, 2024
9fcdecc
Merge pull request #4670 from coralproject/fix/CORL-3188-fix-broken-w…
tessalt Sep 30, 2024
cdd3924
update docs new docusaurus plus lunrjs search
kabeaty Oct 1, 2024
03eb9e6
update order of npm build
kabeaty Oct 1, 2024
1fd0048
fix linting setup
kabeaty Oct 1, 2024
7a036fc
get rid of duplicate api path warning
kabeaty Oct 1, 2024
c8ef50e
fix a few links
kabeaty Oct 1, 2024
7ff9afd
fix up some schema links
kabeaty Oct 1, 2024
3067cf2
Add a safety check for tenant.dsa in external phase
rigperro Oct 2, 2024
b47c033
some cleanup
kabeaty Oct 2, 2024
9e183ad
more cleanup
kabeaty Oct 2, 2024
92ba1b1
support for non-latin character range when creating count query ref
kabeaty Oct 2, 2024
b44bf19
simplify if
kabeaty Oct 2, 2024
f08318f
copy update
kabeaty Oct 2, 2024
4011d81
fix if check update
kabeaty Oct 2, 2024
546484f
fix test
kabeaty Oct 2, 2024
c4be6c8
add TextEncoder to test framework setup for count script test
kabeaty Oct 2, 2024
0a9ad0b
Expose the existing COMMENT_ENTERED_MODERATION_QUEUE event as a webho…
ddrysdale-ffx Oct 1, 2024
d80f5de
Merge pull request #4671 from coralproject/feat/CORL-3179-dsa-rejecte…
tessalt Oct 3, 2024
6b4da09
Merge pull request #4669 from coralproject/fix/CORL-3180-dont-autopla…
tessalt Oct 3, 2024
0887ccb
Merge pull request #4672 from coralproject/spike/CORL-3186-update-docs
tessalt Oct 3, 2024
e21ea69
Merge branch 'develop' into feat/webhook-comment-entered-moderation-q…
tessalt Oct 3, 2024
1549624
Merge branch 'develop' into develop
tessalt Oct 3, 2024
ef2c3a1
Merge pull request #4675 from coralproject/fix/CORL-3189-language-urls
tessalt Oct 3, 2024
17b95fa
Merge branch 'develop' into develop
tessalt Oct 3, 2024
34a7851
update to 9.4.0
tessalt Oct 3, 2024
44ca0a7
Merge pull request #4677 from coralproject/release-9.4.0
tessalt Oct 3, 2024
b059364
Merge branch 'develop' into develop
tessalt Oct 3, 2024
5bafac1
Merge pull request #4674 from rigperro/develop
tessalt Oct 3, 2024
746ff7a
Merge branch 'develop' into feat/webhook-comment-entered-moderation-q…
tessalt Oct 3, 2024
fe771bd
Merge pull request #4673 from ddrysdale-ffx/feat/webhook-comment-ente…
tessalt Oct 3, 2024
32ed22d
Merge branch 'main' into develop
tessalt Oct 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions client/src/core/client/count/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import { COUNT_SELECTOR } from "coral-framework/constants";
import detectCountScript from "coral-framework/helpers/detectCountScript";
import resolveStoryURL from "coral-framework/helpers/resolveStoryURL";
import {
bytesToBase64,
detectCountScript,
resolveStoryURL,
} from "coral-framework/helpers";
import jsonp from "coral-framework/utils/jsonp";

import injectJSONPCallback from "./injectJSONPCallback";
Expand All @@ -13,7 +16,7 @@ interface CountQueryArgs {

/** createCountQueryRef creates a unique reference from the query args */
function createCountQueryRef(args: CountQueryArgs) {
return btoa(`${args.url}`);
return bytesToBase64(new TextEncoder().encode(`${args.url}`));
}

interface DetectAndInjectArgs {
Expand Down
6 changes: 6 additions & 0 deletions client/src/core/client/framework/helpers/bytesToBase64.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
export default function bytesToBase64(bytes: Uint8Array) {
const binString = Array.from(bytes, (byte) =>
String.fromCodePoint(byte)
).join("");
return btoa(binString);
}
1 change: 1 addition & 0 deletions client/src/core/client/framework/helpers/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
export { default as bytesToBase64 } from "./bytesToBase64";
export { default as clearHash } from "./clearHash";
export { default as createContextHOC } from "./createContextHOC";
export { default as detectCommentEmbedScript } from "./detectCommentEmbedScript";
Expand Down
4 changes: 4 additions & 0 deletions client/src/core/client/test/setupTestFramework.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import "@testing-library/jest-dom";
import { toHaveNoViolations } from "jest-axe";
import { TextEncoder } from "util";

import expectAndFail from "./expectAndFail";

Expand All @@ -14,6 +15,9 @@ import "./setupConsole";
// to get around: https://github.com/facebook/jest/issues/3917
(global as any).expectAndFail = expectAndFail;

// we need to have this for count script
(global as any).TextEncoder = TextEncoder;

// Log unhandled rejections.
// eslint-disable-next-line no-console
process.on("unhandledRejection", (err) => {
Expand Down