Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-3195]: more error handling and type check fixes #4683

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

kabeaty
Copy link
Contributor

@kabeaty kabeaty commented Oct 9, 2024

What does this PR do?

These changes:

  • Make sure that we're checking that a tenant has media and gifs defined before checking that it is enabled/supported. This was throwing errors when gifs wasn't defined.
  • Because non-error exception volume increased after Tenor option was introduced, attempt to check type of new error caught and thrown within these changes, and update what's thrown if it is not an instance of Error.

Also, if after these changes we are still seeing issues with non-error exceptions being thrown, we can add a check in services/errors/sentry for instance of Error and handle accordingly. I kept out of these changes to try one step at a time.

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

none

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

Check that comments with Tenor gifs still work as expected.

Were any tests migrated to React Testing Library?

How do we deploy this PR?

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit d492591
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/6706cded67e72900084e6266

@kabeaty kabeaty requested review from nick-funk and tessalt October 9, 2024 18:40
Copy link
Contributor

@nick-funk nick-funk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@tessalt tessalt merged commit 8094b3e into develop Oct 22, 2024
6 checks passed
@tessalt tessalt deleted the fix/CORL-3195-non-error-exceptions branch October 22, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants