[CORL-3195]: more error handling and type check fixes #4683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These changes:
media
andgifs
defined before checking that it is enabled/supported. This was throwing errors whengifs
wasn't defined.Error
.Also, if after these changes we are still seeing issues with non-error exceptions being thrown, we can add a check in
services/errors/sentry
for instance ofError
and handle accordingly. I kept out of these changes to try one step at a time.These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
none
Does this PR introduce any new environment variables or feature flags?
no
If any indexes were added, were they added to
INDEXES.md
?n/a
How do I test this PR?
Check that comments with Tenor gifs still work as expected.
Were any tests migrated to React Testing Library?
How do we deploy this PR?