Accept NULL values for Picture and Name values for OCID responses

[piscis]

What does this PR do?

This PR enabled OCID payloads to contain name and picture keys with NULL values. This is especially important in case you connect a third party IDP solution like logto.io or keycloak which estables logins via SignIn with apple.

By allowing name and picture to be defined as null its possible to use login provider that do not provide the name or picture for a user but encode them as null values in the OCID token exchange.

Corresponding ISSUE: #4701

These changes will impact:

• commenters
• moderators
• admins
• developers

What changes to the GraphQL/Database Schema does this PR introduce?

None

Does this PR introduce any new environment variables or feature flags?

None

If any indexes were added, were they added to INDEXES.md?

None

How do I test this PR?

Method 1:

1. Setup a development server with this pr
2. Register a Free logto.io instance
3. Configure a third party OCID application inside logto.io - https://docs.logto.io/integrations/third-party-oidc/
4. Configure the OCID connector inside your Coral Talk
5. Configure SignIn with Apple inside of the logto instance
6. LogIn with apple
7. During registration a user should be able to sign up and pick a username

Methode 2:

1. Mock the token exchange between your IDP and CoralTalk by setting the picture and name element to null

Were any tests migrated to React Testing Library?

No

How do we deploy this PR?

No actions needed

[netlify]

✅ Deploy Preview for gallant-galileo-14878c canceled.

Name	Link
🔨 Latest commit	4f51bb0
🔍 Latest deploy log	https://app.netlify.com/sites/gallant-galileo-14878c/deploys/6745f5b505bf520009b96e0d

[tessalt]

Hi there! thanks so much for your submission and bug report. I'm going to close this in favour of #4704 but thanks again!

[piscis]

Hi @tessalt thanks for the reply I had a look at the other PR, I'm not an expert on JOI but I thought you have to flag it as allow(null) values and not optional because you already flagging picture and name as optional with the fork statement here down below.

talk/server/src/core/server/services/oidc/oidc.ts

Lines 59 to 69 in 734a768

	.fork(
	[
	"picture",
	"email",
	"email_verified",
	"name",
	"nickname",
	"preferred_username",
	],
	(s) => s.optional()
	);

I'm going to test PR #4704 with Apple SignIn as soon as its released and report back if there are problems. Thanks again for looking into it