Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-3202] don't show the Refresh comments button when live updates are disabled #4703

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

nick-funk
Copy link
Contributor

What does this PR do?

  • turns off the Refresh comments button when live updates are disabled in the tenant settings

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

None

Does this PR introduce any new environment variables or feature flags?

No

If any indexes were added, were they added to INDEXES.md?

N/A

How do I test this PR?

  • disable live updates under Admin > Configure > Advanced > Comment stream live updates
  • go to stream
  • leave stream tab and come back
  • no Reload comments button/prompt should show

Were any tests migrated to React Testing Library?

No

How do we deploy this PR?

  • Merge into develop

@nick-funk nick-funk requested review from tessalt and kabeaty November 28, 2024 16:27
Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit 896465d
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/67489c8743568e00088b03da

Copy link
Contributor

@kabeaty kabeaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm when testing these changes, if the live setting is enabled again in the admin, I'm not seeing the refresh comments button showing then as expected. Are you able to reproduce that?

@nick-funk
Copy link
Contributor Author

Hmm when testing these changes, if the live setting is enabled again in the admin, I'm not seeing the refresh comments button showing then as expected. Are you able to reproduce that?

I am unfortunately not. I did the following to test:

  • started up a fresh tenant
  • went to stream and signed in
  • posted a comment
  • switched tabs
  • came back
  • stream was showing Refresh comments
  • opened a new tab
  • went to admin > config > advanced > Comment stream live updates
  • disabled the live updates feature
  • saved changes
  • go back to stream tab
  • hard refreshed my stream
  • switched tabs
  • came back
  • I no longer see the Refresh comments button
  • again, went to admin > config > advanced > Comment stream live updates
  • enabled the live updates feature
  • saved changes
  • go back to stream tab
  • hard refreshed my stream
  • switched tabs
  • came back
  • I once again see the Refresh comments button in stream

Copy link
Contributor

@kabeaty kabeaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it working, looks good!

@tessalt tessalt merged commit 10fb973 into develop Dec 3, 2024
6 checks passed
@tessalt tessalt deleted the fix/CORL-3203-live-updates-refresh branch December 3, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants