[CORL-3202] Add bluesky to embed options #4705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
something weird is still going on, the oembeds don't show up properly in preview or when embedded in the media view
the preview is still trying to use GifPreview for some reason?
✅ Deploy Preview for gallant-galileo-14878c canceled.
|
finally found it!
it's a bit worrying just how many places you need to update to add one media type 😅
kabeaty
reviewed
Dec 2, 2024
There was a problem hiding this comment.
looking good overall. I left a few comments throughout. Main things are that I'm not seeing the Bluesky embed logo with the confirmation prompt when adding a link to a comment, and embeds don't seem to be adding their embed html correctly (seeing an error in the console).
client/src/core/client/admin/components/MediaContainer/BlueskyMedia.tsx
Outdated
Show resolved
Hide resolved
client/src/core/client/admin/routes/Configure/sections/General/MediaLinksConfig.tsx
Outdated
Show resolved
Hide resolved
client/src/core/client/stream/tabs/Comments/Comment/MediaConfirmation/MediaConfirmationIcon.tsx
Outdated
Show resolved
Hide resolved
client/src/core/client/stream/tabs/Comments/Stream/CommentForm/MediaField.tsx
Outdated
Show resolved
Hide resolved
nick-funk
force-pushed
the
feat/CORL-3202-bluesky-oembed
branch
from
956f6f9 to
18b8724
Compare
…nto feat/CORL-3202-bluesky-oembed
kabeaty
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds Bluesky embeds to the list of various other oembed types we support.
TODO
figure out why the media preview is trying to useGifPreviewfor the Bluesky embed typethis is weird, but at least everything else is workingThese changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
Adds various
BlueskyMediatypes and inputs (same as say,TwitterMedia)Does this PR introduce any new environment variables or feature flags?
No
If any indexes were added, were they added to
INDEXES.md?N/A
How do I test this PR?
Admin > Config > General > Embedded mediaWere any tests migrated to React Testing Library?
No
How do we deploy this PR?
develop