Fix: ssoURL not updated from sso token #4713
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gallant-galileo-14878c canceled.
|
kabeaty
approved these changes
Dec 11, 2024
|
FYI: I didn't test it locally, y'all think I can still merge this? @nick-funk @kabeaty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The user
ssoURLis currently not updated via an sso token, so existing users on The Verge that were created for Chorus still opens the old chorus profile page when clicking onAccount.The Coral SSO Token that we send has the correct
urlset:but Coral is still using the old link
https://www.theverge.com/users/cvle/accountinstead.These changes will impact:
How do I test this PR?
Help me test this :-)
Were any tests migrated to React Testing Library?
No
How do we deploy this PR?
Help me with this :-)