Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search dropdown: clear search when closed #698

Merged
merged 4 commits into from
Jun 23, 2017

Conversation

ALawliet
Copy link

@ALawliet ALawliet commented Jun 22, 2017

https://www.pivotaltracker.com/n/projects/1863625/stories/147545927

What does this PR do?

The search dropdown now clears when closed.

clear-search

How do I test this PR?

  • open search dropdown
  • type something in the input
  • search if you want

try one of the following:

  • close search dropdown by clicking out of it
  • close search dropdown by pressing Esc
  • close search dropdown by clicking a Story
  • close search dropdown by clicking "Moderate comments on All Stories"
  • close search dropdown by clicking top navigation tabs e.g. Moderate -> Stories

then:

  • open search dropdown again
  • notice search was cleared

@kgardnr
Copy link
Contributor

kgardnr commented Jun 22, 2017

Thanks @ALawliet! This is awesome. I'm not sure why the build is showing as failed if it passed?

@kgardnr
Copy link
Contributor

kgardnr commented Jun 22, 2017

Hey @ALawliet! We figured out what's happening - the branch needs to be a different name than master, otherwise it tries to trigger our build - could you update this and try again? Thanks!

@kgardnr kgardnr requested a review from cvle June 23, 2017 08:43
Copy link
Contributor

@cvle cvle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kgardnr kgardnr merged commit 7d84cff into coralproject:master Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants