This repository has been archived by the owner on Sep 18, 2020. It is now read-only.
Core upload update signing #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use variable for the image name - add COREOS prefixed variables so we can start weaning ourself off of the others.
| @@ -42,6 +42,9 @@ switch_to_strict_mode | |||
| [[ -z "${FLAGS_private_key}" ]] && die "--private_key is required" | |||
| [[ -z "${FLAGS_public_key}" ]] && die "--public_key is required" | |||
|
|
|||
| # Put our public key in a place that update_engine can find it | |||
| ../platform/vboot_reference/scripts/image_signing/insert_au_publickey.sh ${FLAGS_image} ${FLAGS_public_key} | |||
There was a problem hiding this comment.
Use ${SRC_ROOT}/platform/etc... (or I think that's the right var name, double check that)
Then you don't depend on the working directory being scripts :)
After that LGTM
shove the public key into the image so it can be found by update_engine
dongsupark
referenced
this pull request
in dongsupark/flatcar-scripts
Jun 30, 2020
build_library: fix qemu key name to org/flatcar-linux
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make signing an update fully automated. The additional step that is new here is that it injects the signing public key into the root filesystem.