Skip to content

Commit

Permalink
fix: use subdirectory for @excalidraw/excalidraw size limit (excalidr…
Browse files Browse the repository at this point in the history
…aw#6787)

* fix: use subdirectory for @excalidraw/excalidraw size limit

* fix

* update yml

* update path

* fix

* fix

* better
  • Loading branch information
ad1992 authored Jul 19, 2023
1 parent 9fc15d8 commit 7088832
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 30 deletions.
8 changes: 7 additions & 1 deletion .github/workflows/size-limit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,16 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: 18.x
- name: Install
run: yarn --frozen-lockfile
- name: Install in src/packages/excalidraw
run: yarn --frozen-lockfile
working-directory: src/packages/excalidraw
env:
CI: true
- uses: andresz1/size-limit-action@v1
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
build_script: size
build_script: build:umd
skip_step: install
directory: src/packages/excalidraw
13 changes: 2 additions & 11 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -145,15 +145,6 @@
"test:coverage": "react-scripts test --passWithNoTests --coverage --watchAll",
"autorelease": "node scripts/autorelease.js",
"prerelease": "node scripts/prerelease.js",
"release": "node scripts/release.js",
"size": "node scripts/buildPackageExcalidraw.js && size-limit"
},
"size-limit": [
{
"path": [
"src/packages/excalidraw/dist/excalidraw.development.js",
"src/packages/excalidraw/dist/excalidraw.production.min.js"
]
}
]
"release": "node scripts/release.js"
}
}
16 changes: 0 additions & 16 deletions scripts/buildPackageExcalidraw.js

This file was deleted.

13 changes: 11 additions & 2 deletions src/packages/excalidraw/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,15 @@
"pack": "yarn build:umd && yarn pack",
"start": "webpack serve --config webpack.dev-server.config.js",
"install:deps": "yarn install --frozen-lockfile && yarn --cwd ../../../",
"build:example": "EXAMPLE=true webpack --config webpack.dev-server.config.js && yarn gen:types"
}
"build:example": "EXAMPLE=true webpack --config webpack.dev-server.config.js && yarn gen:types",
"size": "yarn build:umd && size-limit"
},
"size-limit": [
{
"path": "dist/excalidraw.development.js"
},
{
"path": "dist/excalidraw.production.min.js"
}
]
}

0 comments on commit 7088832

Please sign in to comment.