Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notes Release (DRAFT) #968

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from
Draft

Notes Release (DRAFT) #968

wants to merge 27 commits into from

Conversation

nidhi-mylavarapu
Copy link
Contributor

Summary

This pull request is the first step towards implementing feature Foo

  • implemented X
  • fixed Y

Remaining TODOs:

  • resolve bug 1
  • implement Z

Depends on #{number of PR}

Test Plan

Notes

Blockers

  • A newly discovered dependency that hasn’t been addressed

Breaking Changes

  • Database schema change (anything that changes Firestore collection structure)
  • Other change that could cause problems (Detailed in notes)

nidhi-mylavarapu and others added 25 commits November 6, 2024 23:37
@nidhi-mylavarapu
initial attempt of sliding with rectangle
4cfb81b
@nidhi-mylavarapu
moved shifting Note to a separate component
d05304d
@nidhi-mylavarapu
sliding notes with lighter color matching course
1d2e4a3
@nidhi-mylavarapu
adde
ff34593 
d filter for pastel note
@nidhi-mylavarapu
added arrow
dd90cba
@nidhi-mylavarapu
using input but wrong styles
bec8497
@nidhi-mylavarapu
note component setup
6ed0d7c
@nidhi-mylavarapu
added note ic
d73a1fc 
on and option to course card menu
@nidhi-mylavarapu
notes icon in course card menu
03dd540
@nidhi-mylavarapu
note shows up after clicking note option in course menu
7f398e6
@nidhi-mylavarapu
lighter colors for notes
ba9c44d
@Destaq
Merge pull request #960 from cornell-dti/nidhi/notes-basic-frontend
478b155 
Notes Basic Frontend
@Destaq
checkpoint: mocked (on-enter) note shaking
a5158d5
@Destaq
chore: run prettier
0dfbb06
@Destaq
refactor: fix some type issues and support saving + editing notes
a9cb55b
@Destaq
feat: collapsing + shaking + refactoring for type-safety and minimalism
9425129
@Destaq
fix: make note component a proper Vue component for type safety
718dbd7
@Destaq
feat: editing & deletion ui footer logic
dade6fd
@Destaq
fix: proper reactivity on delete
30468d3
@Destaq
style: figma consistency updates for color + icons
b2630b5
@Destaq
fix: attempt type fixes (not running locally)
40c073a
@Destaq
fix: type cleanup
2ac629b
@Destaq
chore: run prettier
67a9b1b
@Destaq
docs: add many inline comments
31c151c
@nidhi-mylavarapu
Merge pull request #966 from cornell-dti/shake-animation-and-storage-…
e60241f 
…ideation

Backend logic, shake animation, and frontend draft for course notes
@dti-github-bot
Copy link
Member

dti-github-bot commented Dec 3, 2024 •
edited
Loading

[diff-counting] Significant lines: 595.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit f6b240f):

https://cornelldti-courseplan-dev--pr968-notes-feature-8xrerbmv.web.app

(expires Wed, 08 Jan 2025 00:54:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933

@plumshum
frontend fixes
7e33104 
- fixed colors
- fixed hover states hopefully?
- fixed icons
- fixed note sizes
- fixed sliding + padding between courses with notes on semester
- fixed z-indexes
@plumshum
Revert "frontend fixes"
f6b240f 
This reverts commit 7e33104.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nidhi-mylavarapu @dti-github-bot @Destaq @plumshum