-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(types/errors)!: update to latest errors module beta #11279
Conversation
Why so many unrelated test failures?? |
Any idea what's happening here anyone? I can't imagine these CI failures are due to this PR and things passed when I tested locally |
I see failing tests in group, it might be related to #11168. We can assign someone to have a look there |
In that case should we consider this safe to merge? |
FYI, @aleem1314 opened a draft PR(#11338) for #11168, and he would like to continue on it. |
@AmauryM there are legitimate errors related to the group module here. I'm not sure if it's just the test that needs to be updated or the code. The test is expecting a different error than the one it got |
Description
Follow-up to #11274
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change