Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types/errors)!: update to latest errors module beta #11279

Merged
merged 22 commits into from
Mar 13, 2022

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Feb 25, 2022

Description

Follow-up to #11274


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Feb 26, 2022
@aaronc
Copy link
Member Author

aaronc commented Feb 28, 2022

Why so many unrelated test failures??

@aaronc
Copy link
Member Author

aaronc commented Mar 8, 2022

Any idea what's happening here anyone? I can't imagine these CI failures are due to this PR and things passed when I tested locally

@amaury1093
Copy link
Contributor

amaury1093 commented Mar 8, 2022

I see failing tests in group, it might be related to #11168. We can assign someone to have a look there

@aaronc
Copy link
Member Author

aaronc commented Mar 8, 2022

I see failing tests in group, it might be related to #11168. We can assign someone to have a look there

In that case should we consider this safe to merge?

@amaury1093
Copy link
Contributor

In that case should we consider this safe to merge?

Merging this now would prevent automerge doing its work on all other PRs. I would advise waiting for #11168, @atheeshp is looking into it

@atheeshp
Copy link
Contributor

atheeshp commented Mar 9, 2022

In that case should we consider this safe to merge?

Merging this now would prevent automerge doing its work on all other PRs. I would advise waiting for #11168, @atheeshp is looking into it

FYI, @aleem1314 opened a draft PR(#11338) for #11168, and he would like to continue on it.

@aaronc
Copy link
Member Author

aaronc commented Mar 11, 2022

@AmauryM there are legitimate errors related to the group module here. I'm not sure if it's just the test that needs to be updated or the code. The test is expecting a different error than the one it got

@github-actions github-actions bot added the C:CLI label Mar 11, 2022
@mergify mergify bot merged commit ec8024e into master Mar 13, 2022
@mergify mergify bot deleted the aaronc/update-errors-mod branch March 13, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:errors C:orm C:Types
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants