Adding jshint; jshinted js file; add more ignores; add node modules

.gitignore

@@ -30,3 +30,6 @@ dwsync.xml
 .svn
 publish
 .idea
+
+## nodejs dependencies
+node_modules

Makefile

@@ -0,0 +1,12 @@
+## config
+JS_ENGINE ?= `which node nodejs 2>/dev/null`
+
+all: test
+## test against jshint
+test:
+	@@if test ! -z ${JS_ENGINE}; then \
+		echo "Checking files against JSHint..."; \
+		${JS_ENGINE} tests/jshint-check.js || return -1 \
+	else \
+		echo "You must have NodeJS installed in order to test js files against JSHint."; \
+	fi

package.json

@@ -0,0 +1,8 @@
+{
+    "name": "ui-coverflow-ii",
+    "version": "2.3.0",
+    "private": true,
+    "dependencies": {
+        "jshint" : ">=0.5.8"
+    }
+}

src/js/ui.coverflow.js

@@ -31,7 +31,7 @@
 		options: {
 			items: "> *",
 			// scale left/right images - 0>x<1
-			itemscale : .73,
+			itemscale : 0.73,
 			orientation: "horizontal",
 			active: 0,
 			duration : 200,
@@ -55,8 +55,7 @@
 			this.currentIndex = o.active;
 
 			if( $.isArray( o.trigger ) ) {
-				// TODO: jshint doesn't like the assignment
-				for( i = 0; binding = o.trigger[ i++ ]; ) {
+				for( i = 0; !! ( binding = o.trigger[ i++ ] ); ) {
 					itemBindings[ binding ] = this._select;
 				}
 
@@ -73,7 +72,7 @@
 			this.origElementDimensions = {
 				width: this.element.width(),
 				height: this.element.height()
-			}
+			};
 			this._on( this.items, itemBindings );
 
 		},
@@ -85,14 +84,14 @@
 			if( o.orientation === "vertical" ) {
 				this._topOrLeft = "top";
 				this._widthOrHeight = "height";
-				if( this._orientation != null && this._orientation == "horizontal" ) {
+				if( this._orientation != null && this._orientation === "horizontal" ) {
 					this._trigger( "orientationchange", null, this._ui() );
 				}
 				this._orientation = "vertical";
 			} else {
 				this._topOrLeft = "left";
 				this._widthOrHeight = "width";
-				if( this._orientation != null && this._orientation == "vertical" ) {
+				if( this._orientation != null && this._orientation === "vertical" ) {
 					this._trigger( "orientationchange", null, this._ui() );
 				}
 				this._orientation = "horizontal";
@@ -101,7 +100,7 @@
 			o.itemscale = parseFloat( o.itemscale );
 			o.itemscale = o.itemscale < 1 && o.itemscale > 0
 				? o.itemscale
-				: .73;
+				: 0.73;
 
 			this.itemSize = o.itemscale * this.items.innerWidth();
 

tests/jshint-check.js

@@ -0,0 +1,69 @@
+var fs = require("fs"),
+	jshint = require("jshint").JSHINT,
+	targets = [
+		"src/js/ui.coverflow.js"
+	],
+	config = {
+		// unfiltered forin
+		forin : true,
+		// allow the new keyword
+		nonew : false,
+		evil : true,
+		browser : true,
+		// allow == null
+		eqnull : true,
+		expr : true,
+		curly : true,
+		// no trailing ws
+		trailing : true,
+		// sloppy ws
+		sloppy : true,
+		// don't tell me how to format my code buddy..
+		strict : false,
+		// crockfords whitespace settings - NOPE
+		white : false,
+		// no undefined vars
+		undef : true,
+		smarttabs : true,
+		noarg : true,
+		noempty : true,
+		// require ===
+		eqeqeq : true,
+		// no bitwise operators plz
+		bitwise : true,
+		indent : 4,
+		eqeq : false,
+		nomen : false,
+		laxbreak : true,
+		loopfunc : true,
+		predef : [
+			"jQuery"
+		],
+		maxerr: 100
+	},
+	content = "";
+
+(function() {
+	if( typeof jshint == "undefined") {
+		console.log("Install JSHint first - run `npm install -g jshint` as root.");
+		return;
+	}
+
+	targets.forEach( function( file, key ) {
+		content = fs.readFileSync( file , "utf8");
+		if ( !! content && jshint( content, config ) ) {
+			console.log( "JSHint check passed for file: " + file );
+		} else {
+			console.log( "JSHint found errors." );
+			jshint.errors.forEach(function( e ) {
+				if ( !e ) { return; }
+				var str = e.evidence ? e.evidence : "",
+				character = e.character === true ? "EOL" : "C" + e.character;
+				if ( str ) {
+					str = str.replace( /\t/g, " " ).trim();
+					console.log( file + ": [line " + e.line + ":" + character + "] " + e.reason + "\n  " + str + "\n");
+				}
+			});
+		}
+	});
+})();