Add bike goal list view and routes #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JF-Cozy
requested review from
Merkur39,
paultranvan and
PolariTOON
as code owners
BundleMonFiles updated (3)
Unchanged files (1)
Total files change +6.05KB +0.84% Final result: ✅ View report in BundleMon website ➡️ |
Merkur39
reviewed
Oct 12, 2022
No problem with BC
- back action button is not centered but fixed to the top - adding a wrapper to style the text block
JF-Cozy
force-pushed
the
feat/BikeGoal
branch
from
15a82d9 to
13d20b9
Compare
Merkur39
approved these changes
Oct 12, 2022
JF-Cozy
force-pushed
the
feat/BikeGoal
branch
from
13d20b9 to
06a49ad
Compare
PolariTOON
reviewed
Oct 13, 2022
| import { countDays } from 'src/lib/timeseries' | ||
|
|
||
| export const getDaysToReach = () => | ||
| flag('coachco2.bikegoal.settings').daysToReach |
There was a problem hiding this comment.
Dans l'état, on a une erreur si le flag n'est pas défini.
Peut-être qu'on aurait pu mettre une valeur par défaut ou émettre une erreur explicite dans ce cas ?
There was a problem hiding this comment.
exact, je me suis posé la question, et je suis parti du principe que de toute façon l'app ne marcherait pas sans et que le flag serait présent sur les instances... un throw explicite serait bien dans ce genre de conclusion 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grâce à une nouvelle route, on accède à une nouvelle page qui liste les trajets
de l'objectif vélo, ainsi que la progression de l'objectif.
Pour l'instant ce n'est que sur l'année en cours.
La requête réel n'est pas encore exploitable (une autre tâche préalable est
nécessaire), on requête dans cette PR tous les trajets de manière classique en
attendant.