Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat : Upgrade cozy UI #895

Merged
merged 3 commits into from
Nov 15, 2022
Merged

Feat : Upgrade cozy UI #895

merged 3 commits into from
Nov 15, 2022

Conversation

cballevre
Copy link
Contributor 

### 🔧 Tech

* Add  PR template
* Convertion from class to functional component
* Upgrade Cozy UI to 77.5.0

I will squash my commit after the PR is accepted.

@cballevre cballevre requested review from Crash-- and zatteo November 14, 2022 17:22
@cballevre
Copy link
Contributor Author

Sry, I will correct the broken test tomorrow.

Crash--
Crash-- reviewed Nov 15, 2022
View reviewed changes
Copy link
Contributor

@Crash-- Crash-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is read and I saw that there is still a node 12 in the travis.yml. You can remove it too :)

@Crash--
Copy link
Contributor

Crash-- commented Nov 15, 2022

Nice work ATM! Appreciate the refactoring to functional component!

@cballevre cballevre force-pushed the feat/upgrade-cozy-ui branch from 3b1fbba to 8f7c897 Compare November 15, 2022 15:10
@cballevre cballevre requested a review from Crash-- November 15, 2022 15:20
@cballevre cballevre force-pushed the feat/upgrade-cozy-ui branch from 8f7c897 to 2641628 Compare November 15, 2022 15:48
@cballevre cballevre merged commit 411ab47 into master Nov 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the feat/upgrade-cozy-ui branch November 15, 2022 16:03
cballevre added a commit that referenced this pull request Nov 23, 2022
@cballevre
fix: add back the StylesProvider with cozy-ui
5306249 
In a previous PR, I remove material-ui dependence to only use cozy-ui. I miss StylesProvider into cozy-ui so I put it back now. cc : #895
cballevre added a commit that referenced this pull request Nov 28, 2022
@cballevre
fix: add back the StylesProvider with cozy-ui
5208db3 
In a previous PR, I remove material-ui dependence to only use cozy-ui. I miss StylesProvider into cozy-ui so I put it back now. cc : #895
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Crash-- Crash-- Crash-- approved these changes

@zatteo zatteo Awaiting requested review from zatteo zatteo is a code owner

@JF-Cozy JF-Cozy Awaiting requested review from JF-Cozy JF-Cozy is a code owner

@Merkur39 Merkur39 Awaiting requested review from Merkur39 Merkur39 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cballevre @Crash--