Optimisation: Large struct pointer conversion (final part) (thrasher-…

…corp#265) Completes large struct pointer optomisations over the entire codebase and enables hugeParams linter by default
cranktakular · Apr 4, 2019 · ca55f2f · ca55f2f
1 parent 107cf76
commit ca55f2f
Show file tree

Hide file tree

Showing 97 changed files with 195 additions and 195 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -65,7 +65,6 @@ linters-settings:
       - experimental
     disabled-checks:
       - wrapperFunc
-      - hugeParam
       - importShadow
       - rangeValCopy
       - methodExprCall

diff --git a/currency/currency.go b/currency/currency.go
@@ -72,7 +72,7 @@ func GetTotalMarketCryptocurrencies() ([]Code, error) {
 }
 
 // RunStorageUpdater  runs a new foreign exchange updater instance
-func RunStorageUpdater(o BotOverrides, m MainConfiguration, filepath string, v bool) error {
+func RunStorageUpdater(o BotOverrides, m *MainConfiguration, filepath string, v bool) error {
 	return storage.RunUpdater(o, m, filepath, v)
 }
 

diff --git a/currency/storage.go b/currency/storage.go
@@ -96,7 +96,7 @@ func (s *Storage) SetDefaults() {
 // dump file and keep foreign exchange rates updated as fast as possible without
 // triggering rate limiters, it will also run a full cryptocurrency check
 // through coin market cap and expose analytics for exchange services
-func (s *Storage) RunUpdater(overrides BotOverrides, settings MainConfiguration, filePath string, verbose bool) error {
+func (s *Storage) RunUpdater(overrides BotOverrides, settings *MainConfiguration, filePath string, verbose bool) error {
 	s.mtx.Lock()
 
 	if !settings.Cryptocurrencies.HasData() {

diff --git a/currency/storage_test.go b/currency/storage_test.go
@@ -5,7 +5,8 @@ import "testing"
 func TestRunUpdater(t *testing.T) {
 	var newStorage Storage
 
-	err := newStorage.RunUpdater(BotOverrides{}, MainConfiguration{}, "", false)
+	emptyMainConfig := MainConfiguration{}
+	err := newStorage.RunUpdater(BotOverrides{}, &emptyMainConfig, "", false)
 	if err == nil {
 		t.Fatal("Test Failed storage RunUpdater() error cannot be nil")
 	}
@@ -15,12 +16,12 @@ func TestRunUpdater(t *testing.T) {
 		FiatDisplayCurrency: USD,
 	}
 
-	err = newStorage.RunUpdater(BotOverrides{}, mainConfig, "", false)
+	err = newStorage.RunUpdater(BotOverrides{}, &mainConfig, "", false)
 	if err == nil {
 		t.Fatal("Test Failed storage RunUpdater() error cannot be nil")
 	}
 
-	err = newStorage.RunUpdater(BotOverrides{}, mainConfig, "/bla", false)
+	err = newStorage.RunUpdater(BotOverrides{}, &mainConfig, "/bla", false)
 	if err != nil {
 		t.Fatal("Test Failed storage RunUpdater() error", err)
 	}

diff --git a/exchange.go b/exchange.go
@@ -84,7 +84,7 @@ func ReloadExchange(name string) error {
 	}
 
 	e := GetExchangeByName(nameLower)
-	e.Setup(exchCfg)
+	e.Setup(&exchCfg)
 	log.Debugf("%s exchange reloaded successfully.\n", name)
 	return nil
 }
@@ -207,7 +207,7 @@ func LoadExchange(name string, useWG bool, wg *sync.WaitGroup) error {
 	}
 
 	exchCfg.Enabled = true
-	exch.Setup(exchCfg)
+	exch.Setup(&exchCfg)
 
 	if useWG {
 		exch.Start(wg)

diff --git a/exchanges/alphapoint/alphapoint_wrapper.go b/exchanges/alphapoint/alphapoint_wrapper.go
@@ -56,7 +56,7 @@ func (a *Alphapoint) UpdateTicker(p currency.Pair, assetType string) (ticker.Pri
 	tickerPrice.Volume = tick.Volume
 	tickerPrice.Last = tick.Last
 
-	err = ticker.ProcessTicker(a.GetName(), tickerPrice, assetType)
+	err = ticker.ProcessTicker(a.GetName(), &tickerPrice, assetType)
 	if err != nil {
 		return tickerPrice, err
 	}

diff --git a/exchanges/anx/anx.go b/exchanges/anx/anx.go
@@ -76,7 +76,7 @@ func (a *ANX) SetDefaults() {
 }
 
 // Setup is run on startup to setup exchange with config values
-func (a *ANX) Setup(exch config.ExchangeConfig) {
+func (a *ANX) Setup(exch *config.ExchangeConfig) {
 	if !exch.Enabled {
 		a.SetEnabled(false)
 	} else {
@@ -102,7 +102,7 @@ func (a *ANX) Setup(exch config.ExchangeConfig) {
 		if err != nil {
 			log.Fatal(err)
 		}
-		err = a.SetAPIURL(&exch)
+		err = a.SetAPIURL(exch)
 		if err != nil {
 			log.Fatal(err)
 		}

diff --git a/exchanges/anx/anx_test.go b/exchanges/anx/anx_test.go
@@ -53,7 +53,7 @@ func TestSetup(t *testing.T) {
 	if err != nil {
 		t.Error("Test Failed - ANX Setup() init error")
 	}
-	a.Setup(anxConfig)
+	a.Setup(&anxConfig)
 	a.APIKey = testAPIKey
 	a.APISecret = testAPISecret
 	a.AuthenticatedAPISupport = true

diff --git a/exchanges/anx/anx_wrapper.go b/exchanges/anx/anx_wrapper.go
@@ -150,7 +150,7 @@ func (a *ANX) UpdateTicker(p currency.Pair, assetType string) (ticker.Price, err
 		tickerPrice.High = 0
 	}
 
-	err = ticker.ProcessTicker(a.GetName(), tickerPrice, assetType)
+	err = ticker.ProcessTicker(a.GetName(), &tickerPrice, assetType)
 	if err != nil {
 		return tickerPrice, err
 	}

diff --git a/exchanges/binance/binance.go b/exchanges/binance/binance.go
@@ -101,7 +101,7 @@ func (b *Binance) SetDefaults() {
 }
 
 // Setup takes in the supplied exchange configuration details and sets params
-func (b *Binance) Setup(exch config.ExchangeConfig) {
+func (b *Binance) Setup(exch *config.ExchangeConfig) {
 	if !exch.Enabled {
 		b.SetEnabled(false)
 	} else {
@@ -127,7 +127,7 @@ func (b *Binance) Setup(exch config.ExchangeConfig) {
 		if err != nil {
 			log.Fatal(err)
 		}
-		err = b.SetAPIURL(&exch)
+		err = b.SetAPIURL(exch)
 		if err != nil {
 			log.Fatal(err)
 		}

diff --git a/exchanges/binance/binance_test.go b/exchanges/binance/binance_test.go
@@ -33,7 +33,7 @@ func TestSetup(t *testing.T) {
 	binanceConfig.AuthenticatedAPISupport = true
 	binanceConfig.APIKey = testAPIKey
 	binanceConfig.APISecret = testAPISecret
-	b.Setup(binanceConfig)
+	b.Setup(&binanceConfig)
 }
 
 func TestGetExchangeValidCurrencyPairs(t *testing.T) {

diff --git a/exchanges/binance/binance_wrapper.go b/exchanges/binance/binance_wrapper.go
@@ -98,7 +98,7 @@ func (b *Binance) UpdateTicker(p currency.Pair, assetType string) (ticker.Price,
 			tickerPrice.Last = tick[y].LastPrice
 			tickerPrice.Low = tick[y].LowPrice
 			tickerPrice.Volume = tick[y].Volume
-			ticker.ProcessTicker(b.Name, tickerPrice, assetType)
+			ticker.ProcessTicker(b.Name, &tickerPrice, assetType)
 		}
 	}
 	return ticker.GetTicker(b.Name, p, assetType)

diff --git a/exchanges/bitfinex/bitfinex.go b/exchanges/bitfinex/bitfinex.go
@@ -118,7 +118,7 @@ func (b *Bitfinex) SetDefaults() {
 }
 
 // Setup takes in the supplied exchange configuration details and sets params
-func (b *Bitfinex) Setup(exch config.ExchangeConfig) {
+func (b *Bitfinex) Setup(exch *config.ExchangeConfig) {
 	if !exch.Enabled {
 		b.SetEnabled(false)
 	} else {
@@ -145,7 +145,7 @@ func (b *Bitfinex) Setup(exch config.ExchangeConfig) {
 		if err != nil {
 			log.Fatal(err)
 		}
-		err = b.SetAPIURL(&exch)
+		err = b.SetAPIURL(exch)
 		if err != nil {
 			log.Fatal(err)
 		}

diff --git a/exchanges/bitfinex/bitfinex_test.go b/exchanges/bitfinex/bitfinex_test.go
@@ -29,7 +29,7 @@ func TestSetup(t *testing.T) {
 	if err != nil {
 		t.Error("Test Failed - Bitfinex Setup() init error")
 	}
-	b.Setup(bfxConfig)
+	b.Setup(&bfxConfig)
 	b.APIKey = testAPIKey
 	b.APISecret = testAPISecret
 	if !b.Enabled || b.AuthenticatedAPISupport || b.RESTPollingDelay != time.Duration(10) ||

diff --git a/exchanges/bitfinex/bitfinex_wrapper.go b/exchanges/bitfinex/bitfinex_wrapper.go
@@ -79,7 +79,7 @@ func (b *Bitfinex) UpdateTicker(p currency.Pair, assetType string) (ticker.Price
 		tick.Volume = tickerNew[x].Volume
 		tick.High = tickerNew[x].High
 
-		err = ticker.ProcessTicker(b.Name, tick, assetType)
+		err = ticker.ProcessTicker(b.Name, &tick, assetType)
 		if err != nil {
 			return tickerPrice, err
 		}

diff --git a/exchanges/bitflyer/bitflyer.go b/exchanges/bitflyer/bitflyer.go
@@ -103,7 +103,7 @@ func (b *Bitflyer) SetDefaults() {
 }
 
 // Setup takes in the supplied exchange configuration details and sets params
-func (b *Bitflyer) Setup(exch config.ExchangeConfig) {
+func (b *Bitflyer) Setup(exch *config.ExchangeConfig) {
 	if !exch.Enabled {
 		b.SetEnabled(false)
 	} else {
@@ -130,7 +130,7 @@ func (b *Bitflyer) Setup(exch config.ExchangeConfig) {
 		if err != nil {
 			log.Fatal(err)
 		}
-		err = b.SetAPIURL(&exch)
+		err = b.SetAPIURL(exch)
 		if err != nil {
 			log.Fatal(err)
 		}

diff --git a/exchanges/bitflyer/bitflyer_test.go b/exchanges/bitflyer/bitflyer_test.go
@@ -35,7 +35,7 @@ func TestSetup(t *testing.T) {
 	bitflyerConfig.APIKey = testAPIKey
 	bitflyerConfig.APISecret = testAPISecret
 
-	b.Setup(bitflyerConfig)
+	b.Setup(&bitflyerConfig)
 }
 
 func TestGetLatestBlockCA(t *testing.T) {

diff --git a/exchanges/bitflyer/bitflyer_wrapper.go b/exchanges/bitflyer/bitflyer_wrapper.go
@@ -66,7 +66,7 @@ func (b *Bitflyer) UpdateTicker(p currency.Pair, assetType string) (ticker.Price
 	tickerPrice.Last = tickerNew.Last
 	tickerPrice.Volume = tickerNew.Volume
 	// tickerPrice.High
-	err = ticker.ProcessTicker(b.GetName(), tickerPrice, assetType)
+	err = ticker.ProcessTicker(b.GetName(), &tickerPrice, assetType)
 	if err != nil {
 		return tickerPrice, err
 	}

diff --git a/exchanges/bithumb/bithumb.go b/exchanges/bithumb/bithumb.go
@@ -85,7 +85,7 @@ func (b *Bithumb) SetDefaults() {
 }
 
 // Setup takes in the supplied exchange configuration details and sets params
-func (b *Bithumb) Setup(exch config.ExchangeConfig) {
+func (b *Bithumb) Setup(exch *config.ExchangeConfig) {
 	if !exch.Enabled {
 		b.SetEnabled(false)
 	} else {
@@ -112,7 +112,7 @@ func (b *Bithumb) Setup(exch config.ExchangeConfig) {
 		if err != nil {
 			log.Fatal(err)
 		}
-		err = b.SetAPIURL(&exch)
+		err = b.SetAPIURL(exch)
 		if err != nil {
 			log.Fatal(err)
 		}

diff --git a/exchanges/bithumb/bithumb_test.go b/exchanges/bithumb/bithumb_test.go
@@ -34,7 +34,7 @@ func TestSetup(t *testing.T) {
 	bitConfig.APIKey = testAPIKey
 	bitConfig.APISecret = testAPISecret
 
-	b.Setup(bitConfig)
+	b.Setup(&bitConfig)
 }
 
 func TestGetTradablePairs(t *testing.T) {

diff --git a/exchanges/bithumb/bithumb_wrapper.go b/exchanges/bithumb/bithumb_wrapper.go
@@ -84,7 +84,7 @@ func (b *Bithumb) UpdateTicker(p currency.Pair, assetType string) (ticker.Price,
 		tp.Volume = tickers[currency].Volume1Day
 		tp.High = tickers[currency].MaxPrice
 
-		err = ticker.ProcessTicker(b.Name, tp, assetType)
+		err = ticker.ProcessTicker(b.Name, &tp, assetType)
 		if err != nil {
 			return tickerPrice, err
 		}

diff --git a/exchanges/bitmex/bitmex.go b/exchanges/bitmex/bitmex.go
@@ -139,7 +139,7 @@ func (b *Bitmex) SetDefaults() {
 }
 
 // Setup takes in the supplied exchange configuration details and sets params
-func (b *Bitmex) Setup(exch config.ExchangeConfig) {
+func (b *Bitmex) Setup(exch *config.ExchangeConfig) {
 	if !exch.Enabled {
 		b.SetEnabled(false)
 	} else {
@@ -164,7 +164,7 @@ func (b *Bitmex) Setup(exch config.ExchangeConfig) {
 		if err != nil {
 			log.Fatal(err)
 		}
-		err = b.SetAPIURL(&exch)
+		err = b.SetAPIURL(exch)
 		if err != nil {
 			log.Fatal(err)
 		}
@@ -218,7 +218,7 @@ func (b *Bitmex) RemoveAPIKey(params APIKeyParams) (bool, error) {
 
 	return keyDeleted, b.SendAuthenticatedHTTPRequest(http.MethodDelete,
 		bitmexEndpointAPIkeys,
-		params,
+		&params,
 		&keyDeleted)
 }
 
@@ -228,7 +228,7 @@ func (b *Bitmex) DisableAPIKey(params APIKeyParams) (APIKey, error) {
 
 	return keyInfo, b.SendAuthenticatedHTTPRequest(http.MethodPost,
 		bitmexEndpointDisableAPIkey,
-		params,
+		&params,
 		&keyInfo)
 }
 
@@ -238,15 +238,15 @@ func (b *Bitmex) EnableAPIKey(params APIKeyParams) (APIKey, error) {
 
 	return keyInfo, b.SendAuthenticatedHTTPRequest(http.MethodPost,
 		bitmexEndpointEnableAPIkey,
-		params,
+		&params,
 		&keyInfo)
 }
 
 // GetTrollboxMessages returns messages from the bitmex trollbox
 func (b *Bitmex) GetTrollboxMessages(params ChatGetParams) ([]Chat, error) {
 	var messages []Chat
 
-	return messages, b.SendHTTPRequest(bitmexEndpointTrollbox, params, &messages)
+	return messages, b.SendHTTPRequest(bitmexEndpointTrollbox, &params, &messages)
 }
 
 // SendTrollboxMessage sends a message to the bitmex trollbox
@@ -255,7 +255,7 @@ func (b *Bitmex) SendTrollboxMessage(params ChatSendParams) ([]Chat, error) {
 
 	return messages, b.SendAuthenticatedHTTPRequest(http.MethodPost,
 		bitmexEndpointTrollboxSend,
-		params,
+		&params,
 		&messages)
 }