Merge branch 'master' of https://github.com/metabase/metabase into da…

…shboards-list

.eslintrc

@@ -2,7 +2,7 @@
     "rules": {
         "strict": [2, "never"],
         "no-undef": 2,
-        "no-unused-vars": [1, {"vars": "all", "args": "none", "varsIgnorePattern": "^(React|PropTypes|Component)$"}],
+        "no-unused-vars": [1, {"vars": "all", "args": "none"}],
         "import/no-commonjs": 1,
         "quotes": 0,
         "camelcase": 0,

OSX/Metabase/Backend/TaskHealthChecker.m

@@ -9,10 +9,10 @@
 #import "TaskHealthChecker.h"
 
 /// Check out health every this many seconds
-static const CGFloat HealthCheckIntervalSeconds = 1.2f;
+static const CGFloat HealthCheckIntervalSeconds = 2.0f;
 
 /// This number should be lower than HealthCheckIntervalSeconds so requests don't end up piling up
-static const CGFloat HealthCheckRequestTimeout = 0.25f;
+static const CGFloat HealthCheckRequestTimeout = 1.75f;
 
 /// After this many seconds of being unhealthy, consider the task timed out so it can be killed
 static const CFTimeInterval TimeoutIntervalSeconds = 60.0f;
@@ -50,7 +50,7 @@ - (void)start {
 
 	[self resetTimeout];
 
-	dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
+	dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_HIGH, 0), ^{
 		self.healthCheckTimer = [NSTimer timerWithTimeInterval:HealthCheckIntervalSeconds target:self selector:@selector(checkHealth) userInfo:nil repeats:YES];
 		self.healthCheckTimer.tolerance = HealthCheckIntervalSeconds / 2.0f;
 		[[NSRunLoop mainRunLoop] addTimer:self.healthCheckTimer forMode:NSRunLoopCommonModes];
@@ -91,8 +91,9 @@ - (void)checkHealth:(void(^)(BOOL healthy))completion {
 }
 
 - (void)checkHealth {
+	// run the health check on the high-priorty GCD queue because it's imperative that it complete so we can get an accurate picture of Mac App health
 	__weak TaskHealthChecker *weakSelf = self;
-	dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_BACKGROUND, 0), ^{
+	dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_HIGH, 0), ^{
 		[weakSelf checkHealth:^(BOOL healthy) {
 			if (!healthy) NSLog(@"😷");
 			if (healthy && !weakSelf.healthy) NSLog(@"✅");

docs/operations-guide/start.md

@@ -98,6 +98,21 @@ If this happens, setting a few JVM options should fix your issue:
 
 Alternatively, you can upgrade to Java 8 instead, which will fix the issue as well.
 
+### Metabase fails to connect to H2 Database on Windows 10
+
+In some situations the Metabase JAR needs to be unblocked so it has permissions to create local files for the application database.
+
+On Windows 10, if you see an error message like
+
+    Exception in thread "main" java.lang.AssertionError: Assert failed: Unable to connect to Metabase DB.
+
+when running the JAR, you can unblock the file by right-clicking, clicking "Properties", and then clicking "Unblock".
+See Microsoft's documentation [here](https://blogs.msdn.microsoft.com/delay/p/unblockingdownloadedfile/) for more details on unblocking downloaded files.
+
+There are a few other reasons why Metabase might not be able to connect to your H2 DB. Metabase connects to the DB over a TCP port, and it's possible
+that something in your `ipconfig` configuration is blocking the H2 port. See the discussion [here](https://github.com/metabase/metabase/issues/1871) for
+details on how to resolve this issue.
+
 
 # Configuring the Metabase Application Database
 

frontend/src/metabase/App.jsx

@@ -1,6 +1,6 @@
 /* @flow weak */
 
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
 import { connect } from "react-redux";
 
 import Navbar from "metabase/nav/containers/Navbar.jsx";

frontend/src/metabase/admin/databases/components/CreatedDatabaseModal.jsx

@@ -1,4 +1,5 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 import { Link } from "react-router";
 
 import ModalContent from "metabase/components/ModalContent.jsx";

frontend/src/metabase/admin/databases/components/DatabaseEditForms.jsx

@@ -1,4 +1,5 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 import cx from "classnames";
 import LoadingAndErrorWrapper from "metabase/components/LoadingAndErrorWrapper.jsx";
 import DatabaseDetailsForm from "metabase/components/DatabaseDetailsForm.jsx";

frontend/src/metabase/admin/databases/components/DeleteDatabaseModal.jsx

@@ -1,4 +1,5 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 
 import ModalContent from "metabase/components/ModalContent.jsx";
 

frontend/src/metabase/admin/databases/containers/DatabaseEditApp.jsx

@@ -1,5 +1,6 @@
 /* eslint "react/prop-types": "warn" */
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 import { connect } from "react-redux";
 
 import MetabaseSettings from "metabase/lib/settings";

frontend/src/metabase/admin/databases/containers/DatabaseListApp.jsx

@@ -1,4 +1,5 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 import { connect } from "react-redux";
 import { Link } from "react-router";
 

frontend/src/metabase/admin/datamodel/components/FormInput.jsx

@@ -1,4 +1,4 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
 
 import cx from "classnames";
 import { formDomOnlyProps } from "metabase/lib/redux";

frontend/src/metabase/admin/datamodel/components/FormLabel.jsx

@@ -1,4 +1,5 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 
 export default class FormLabel extends Component {
     static propTypes = {

frontend/src/metabase/admin/datamodel/components/FormTextArea.jsx

@@ -1,4 +1,4 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
 
 import cx from "classnames";
 

frontend/src/metabase/admin/datamodel/components/ObjectActionSelect.jsx

@@ -1,4 +1,5 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 import { Link } from "react-router";
 
 import Icon from "metabase/components/Icon.jsx";

frontend/src/metabase/admin/datamodel/components/ObjectRetireModal.jsx

@@ -1,4 +1,4 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
 import ReactDOM from "react-dom";
 
 import ActionButton from "metabase/components/ActionButton.jsx";

frontend/src/metabase/admin/datamodel/components/PartialQueryBuilder.jsx

@@ -1,4 +1,5 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 
 import GuiQueryEditor from "metabase/query_builder/components/GuiQueryEditor.jsx";
 

frontend/src/metabase/admin/datamodel/components/database/ColumnItem.jsx

@@ -1,4 +1,5 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 
 import Input from "metabase/components/Input.jsx";
 import Select from "metabase/components/Select.jsx";

frontend/src/metabase/admin/datamodel/components/database/ColumnsList.jsx

@@ -1,4 +1,5 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 
 import ColumnItem from "./ColumnItem.jsx";
 

frontend/src/metabase/admin/datamodel/components/database/MetadataHeader.jsx

@@ -1,4 +1,5 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 
 import SaveStatus from "metabase/components/SaveStatus.jsx";
 import Toggle from "metabase/components/Toggle.jsx";

frontend/src/metabase/admin/datamodel/components/database/MetadataSchema.jsx

@@ -1,4 +1,5 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 
 export default class MetadataSchema extends Component {
     static propTypes = {

frontend/src/metabase/admin/datamodel/components/database/MetadataSchemaList.jsx

@@ -1,4 +1,4 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
 
 import Icon from "metabase/components/Icon.jsx";
 

frontend/src/metabase/admin/datamodel/components/database/MetadataTable.jsx

@@ -1,4 +1,5 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 
 import MetricsList from "./MetricsList.jsx";
 import ColumnsList from "./ColumnsList.jsx";

frontend/src/metabase/admin/datamodel/components/database/MetadataTableList.jsx

@@ -1,4 +1,5 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 
 import ProgressBar from "metabase/components/ProgressBar.jsx";
 import Icon from "metabase/components/Icon.jsx";

frontend/src/metabase/admin/datamodel/components/database/MetadataTablePicker.jsx

@@ -1,4 +1,5 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 
 import MetadataTableList from "./MetadataTableList.jsx";
 import MetadataSchemaList from "./MetadataSchemaList.jsx";

frontend/src/metabase/admin/datamodel/components/database/MetricItem.jsx

@@ -1,4 +1,5 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 
 import ObjectActionSelect from "../ObjectActionSelect.jsx";
 

frontend/src/metabase/admin/datamodel/components/database/MetricsList.jsx

@@ -1,4 +1,5 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 import { Link } from "react-router";
 
 import MetricItem from "./MetricItem.jsx";

frontend/src/metabase/admin/datamodel/components/database/SegmentItem.jsx

@@ -1,4 +1,5 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 
 import ObjectActionSelect from "../ObjectActionSelect.jsx";
 

frontend/src/metabase/admin/datamodel/components/database/SegmentsList.jsx

@@ -1,4 +1,5 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 import { Link } from "react-router";
 
 import SegmentItem from "./SegmentItem.jsx";

frontend/src/metabase/admin/datamodel/components/revisions/QueryDiff.jsx

@@ -1,4 +1,5 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 
 import LoadingAndErrorWrapper from "metabase/components/LoadingAndErrorWrapper.jsx";
 

frontend/src/metabase/admin/datamodel/components/revisions/Revision.jsx

@@ -1,4 +1,5 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 
 import RevisionDiff from "./RevisionDiff.jsx";
 

frontend/src/metabase/admin/datamodel/components/revisions/RevisionDiff.jsx

@@ -1,4 +1,5 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 
 import TextDiff from "./TextDiff.jsx";
 import QueryDiff from "./QueryDiff.jsx";

frontend/src/metabase/admin/datamodel/components/revisions/RevisionHistory.jsx

@@ -1,4 +1,5 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 
 import Revision from "./Revision.jsx";
 

frontend/src/metabase/admin/datamodel/components/revisions/TextDiff.jsx

@@ -1,6 +1,7 @@
 /*eslint-env node */
 
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 
 import { diffWords } from 'diff';
 

frontend/src/metabase/admin/datamodel/containers/MetadataEditorApp.jsx

@@ -1,4 +1,5 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 import { connect } from "react-redux";
 
 import _ from "underscore";

frontend/src/metabase/admin/datamodel/containers/MetricApp.jsx

@@ -1,4 +1,4 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
 import { connect } from "react-redux";
 import { push } from "react-router-redux";
 

frontend/src/metabase/admin/datamodel/containers/MetricForm.jsx

@@ -1,4 +1,4 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
 import { Link } from "react-router";
 
 import FormLabel from "../components/FormLabel.jsx";

frontend/src/metabase/admin/datamodel/containers/RevisionHistoryApp.jsx

@@ -1,4 +1,4 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
 import { connect } from "react-redux";
 
 import RevisionHistory from "../components/revisions/RevisionHistory.jsx";

frontend/src/metabase/admin/datamodel/containers/SegmentApp.jsx

@@ -1,4 +1,4 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
 import { connect } from "react-redux";
 import { push } from "react-router-redux";
 

frontend/src/metabase/admin/datamodel/containers/SegmentForm.jsx

@@ -1,4 +1,4 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
 import { Link } from "react-router";
 
 import FormLabel from "../components/FormLabel.jsx";

frontend/src/metabase/admin/people/components/AddRow.jsx

@@ -1,4 +1,4 @@
-import React, { Component, PropTypes } from "react";
+import React from "react";
 
 import cx from "classnames";
 

frontend/src/metabase/admin/people/components/EditUserForm.jsx

@@ -1,5 +1,6 @@
 /* eslint "react/prop-types": "warn" */
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 import ReactDOM from "react-dom";
 
 import FormField from "metabase/components/form/FormField.jsx";

frontend/src/metabase/admin/people/components/GroupSelect.jsx

@@ -1,4 +1,4 @@
-import React, { Component, PropTypes } from "react";
+import React from "react";
 
 import CheckBox from "metabase/components/CheckBox.jsx";
 

frontend/src/metabase/admin/people/components/GroupSummary.jsx

@@ -1,4 +1,4 @@
-import React, { Component, PropTypes } from "react";
+import React from "react";
 
 import _ from "underscore";
 

frontend/src/metabase/admin/people/components/UserActionsSelect.jsx

@@ -1,5 +1,6 @@
 /* eslint "react/prop-types": "warn" */
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 
 import Icon from "metabase/components/Icon.jsx";
 import MetabaseSettings from "metabase/lib/settings";

frontend/src/metabase/admin/people/components/UserGroupSelect.jsx

@@ -1,5 +1,6 @@
 /* eslint "react/prop-types": "warn" */
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 import cx from "classnames";
 
 import Icon from "metabase/components/Icon.jsx";

frontend/src/metabase/admin/people/containers/AdminPeopleApp.jsx

@@ -1,5 +1,6 @@
 /* eslint "react/prop-types": "warn" */
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 
 import { LeftNavPane, LeftNavPaneItem } from "metabase/components/LeftNavPane.jsx";
 

frontend/src/metabase/admin/people/containers/PeopleListingApp.jsx

@@ -1,5 +1,6 @@
 /* eslint "react/prop-types": "warn" */
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
+import PropTypes from "prop-types";
 import { Link } from "react-router";
 import _ from "underscore";
 import { connect } from "react-redux";

frontend/src/metabase/admin/permissions/components/FixedHeaderGrid.jsx

@@ -1,6 +1,6 @@
 /* eslint-disable react/display-name */
 
-import React, { Component, PropTypes } from "react";
+import React from "react";
 
 import { Grid, ScrollSync } from 'react-virtualized'
 import 'react-virtualized/styles.css';

frontend/src/metabase/admin/permissions/components/PermissionsConfirm.jsx

@@ -1,4 +1,4 @@
-import React, { Component, PropTypes } from "react";
+import React from "react";
 
 import { inflect } from "metabase/lib/formatting";
 

frontend/src/metabase/admin/permissions/components/PermissionsEditor.jsx

@@ -1,4 +1,4 @@
-import React, { Component, PropTypes } from "react";
+import React from "react";
 
 import LoadingAndErrorWrapper from "metabase/components/LoadingAndErrorWrapper.jsx";
 import Confirm from "metabase/components/Confirm.jsx";

frontend/src/metabase/admin/permissions/components/PermissionsGrid.jsx

@@ -1,6 +1,6 @@
 /* eslint-disable react/display-name */
 
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
 
 import { Link } from "react-router";
 

frontend/src/metabase/admin/permissions/containers/CollectionsPermissionsApp.jsx

@@ -1,4 +1,4 @@
-import React, { Component, PropTypes } from "react";
+import React, { Component } from "react";
 import { connect } from "react-redux";
 
 import PermissionsEditor from "../components/PermissionsEditor.jsx";