Skip to content

Commit

Permalink
MDL-71580 lang: Fix reworded strings in tests
Browse files Browse the repository at this point in the history
  • Loading branch information
mudrd8mz committed May 12, 2021
1 parent c8dc7bc commit 03402e3
Show file tree
Hide file tree
Showing 7 changed files with 23 additions and 23 deletions.
4 changes: 2 additions & 2 deletions admin/tool/brickfield/tests/behat/accessresults.feature
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ Feature: Brickfield activityresults
And I run the scheduled task "\tool_brickfield\task\bulk_process_caches"
And I navigate to "Accessibility toolkit" in current page administration
And I should see "Error details: course Course 1"
And I should see "Overall page content length"
And I should see "\"Bold\" (b) elements should not be used"
And I should see "The overall page content length"
And I should see "Bold (b) elements should not be used"
And I should see "Link text should be descriptive"
And I follow "Activity breakdown"
Then I should see "Results per activity: course Course 1"
Expand Down
20 changes: 10 additions & 10 deletions admin/tool/oauth2/tests/behat/basic_settings.feature
Original file line number Diff line number Diff line change
Expand Up @@ -142,29 +142,29 @@ Feature: Basic OAuth2 functionality
And I should see "Identity issuer deleted"
And I should not see "Testing service modified"

Scenario: Create, edit and delete standard service for OpenBadges
Given I press "OpenBadges"
And I should see "Create new service: OpenBadges"
Scenario: Create, edit and delete standard service for Open Badges
Given I press "Open Badges"
And I should see "Create new service: Open Badges"
And I set the following fields to these values:
| Client ID | thisistheclientid |
| Client secret | supersecret |
| Service base URL | https://dc.imsglobal.org/ |
When I press "Save changes"
Then I should see "Changes saved"
And I should see "OpenBadges"
And "Allow services" "icon" should exist in the "OpenBadges" "table_row"
And "Do not allow login" "icon" should exist in the "OpenBadges" "table_row"
And "Service discovery successful" "icon" should exist in the "OpenBadges" "table_row"
And I should see "Open Badges"
And "Allow services" "icon" should exist in the "Open Badges" "table_row"
And "Do not allow login" "icon" should exist in the "Open Badges" "table_row"
And "Service discovery successful" "icon" should exist in the "Open Badges" "table_row"
And the "src" attribute of "table.admintable th img" "css_element" should contain "IMS-Global-Logo.png"
And I click on "Configure endpoints" "link" in the "OpenBadges" "table_row"
And I click on "Configure endpoints" "link" in the "Open Badges" "table_row"
And I should see "https://dc.imsglobal.org/.well-known/badgeconnect.json" in the "discovery_endpoint" "table_row"
And I should see "authorization_endpoint"
And I follow "OAuth 2 services"
And I click on "Configure user field mappings" "link" in the "OpenBadges" "table_row"
And I click on "Configure user field mappings" "link" in the "Open Badges" "table_row"
And I should not see "given_name"
And I should not see "middle_name"
And I follow "OAuth 2 services"
And I click on "Edit" "link" in the "OpenBadges" "table_row"
And I click on "Edit" "link" in the "Open Badges" "table_row"
And I set the following fields to these values:
| Name | IMS Global |
And I press "Save changes"
Expand Down
2 changes: 1 addition & 1 deletion backup/upgrade.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ information provided here is intended especially for developers.

=== 3.11 ===

* New setting called "Include override permissions" has been implemented. The default
* New setting called "Include permission overrides" has been implemented. The default
settings is OFF for import, and ON for restore.

=== 3.10 ===
Expand Down
4 changes: 2 additions & 2 deletions backup/util/ui/tests/behat/import_course.feature
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Feature: Import course's contents into another course
| enrol/manual:enrol | Allow | teacher | Course | C1 |
And I log in as "teacher1"
When I import "Course 1" course into "Course 2" course using this options:
| Initial | Include override permissions | 1 |
| Initial | Include permission overrides | 1 |
And I navigate to "Users > Permissions" in current page administration
Then I should see "Non-editing teacher (1)"
And I set the field "Advanced role override" to "Non-editing teacher (1)"
Expand All @@ -52,6 +52,6 @@ Feature: Import course's contents into another course
| enrol/manual:enrol | Allow | teacher | Course | C1 |
And I log in as "teacher1"
When I import "Course 1" course into "Course 2" course using this options:
| Initial | Include override permissions | 0 |
| Initial | Include permission overrides | 0 |
And I navigate to "Users > Permissions" in current page administration
Then I should see "Non-editing teacher (0)"
4 changes: 2 additions & 2 deletions backup/util/ui/tests/behat/restore_moodle2_courses.feature
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ Feature: Restore Moodle 2 course backups
And I backup "Course 1" course using this options:
| Confirmation | Filename | test_backup.mbz |
When I restore "test_backup.mbz" backup into a new course using this options:
| Settings | Include override permissions | 1 |
| Settings | Include permission overrides | 1 |
Then I navigate to "Users > Permissions" in current page administration
And I should see "Non-editing teacher (1)"
And I set the field "Advanced role override" to "Non-editing teacher (1)"
Expand All @@ -267,6 +267,6 @@ Feature: Restore Moodle 2 course backups
And I backup "Course 1" course using this options:
| Confirmation | Filename | test_backup.mbz |
When I restore "test_backup.mbz" backup into a new course using this options:
| Settings | Include override permissions | 0 |
| Settings | Include permission overrides | 0 |
Then I navigate to "Users > Permissions" in current page administration
And I should see "Non-editing teacher (0)"
10 changes: 5 additions & 5 deletions blocks/accessreview/tests/behat/accessreview_results.feature
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ Feature: Block accessreview results
And I should see "1" in the "Link" "table_row"
# We created one text issue, and the standard Behat course generator creates another (too much content).
And I should see "2" in the "Text" "table_row"
And "View Brickfield accessibility toolkit" "icon" should exist in the "Accessibility review" "block"
And "Toggle Brickfield accessibility heatmap" "icon" should exist in the "Accessibility review" "block"
And "Download Brickfield accessibility summary report" "icon" should exist in the "Accessibility review" "block"
And "View accessibility toolkit" "icon" should exist in the "Accessibility review" "block"
And "Toggle accessibility heatmap" "icon" should exist in the "Accessibility review" "block"
And "Download accessibility summary report" "icon" should exist in the "Accessibility review" "block"

Scenario: Toggle highlighting on/off
Given I log in as "admin"
Expand All @@ -61,7 +61,7 @@ Feature: Block accessreview results
And I run the scheduled task "\tool_brickfield\task\bulk_process_courses"
And I run the scheduled task "\tool_brickfield\task\bulk_process_caches"
And I reload the page
And I click on "Toggle Brickfield accessibility heatmap" "icon"
And I click on "Toggle accessibility heatmap" "icon"
And ".block_accessreview_view" "css_element" should be visible
And I click on "Toggle Brickfield accessibility heatmap" "icon"
And I click on "Toggle accessibility heatmap" "icon"
And ".block_accessreview_view" "css_element" should not be visible
2 changes: 1 addition & 1 deletion lib/classes/oauth2/service/imsobv2p1.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class imsobv2p1 extends imsbadgeconnect implements issuer_interface {
*/
public static function init(): ?issuer {
$record = (object) [
'name' => 'OpenBadges',
'name' => 'Open Badges',
'image' => '',
'servicetype' => 'imsobv2p1',
];
Expand Down

0 comments on commit 03402e3

Please sign in to comment.