MDL-57791 analytics: Add missing 'new' to throw

Also other code refinements. Credit to Mark Nelson.
crazyserver · Jul 24, 2017 · 08015e1 · 08015e1
1 parent 2db6e98
commit 08015e1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/analytics/classes/calculable.php b/analytics/classes/calculable.php
@@ -208,7 +208,7 @@ protected function classify_value($value, $ranges) {
             $match = false;
 
             if (count($range) != 2) {
-                throw \coding_exception('classify_value() $ranges array param should contain 2 items, the predicate ' .
+                throw new \coding_exception('classify_value() $ranges array param should contain 2 items, the predicate ' .
                     'e.g. greater (gt), lower or equal (le)... and the value.');
             }
 

diff --git a/analytics/classes/manager.php b/analytics/classes/manager.php
@@ -76,7 +76,7 @@ public static function check_can_list_insights(\context $context) {
      *
      * @param bool $enabled
      * @param bool $trained
-     * @param \context $predictioncontext
+     * @param \context|false $predictioncontext
      * @return \core_analytics\model[]
      */
     public static function get_all_models($enabled = false, $trained = false, $predictioncontext = false) {
@@ -163,7 +163,7 @@ public static function get_predictions_processor($predictionclass = false, $chec
     /**
      * Return all system predictions processors.
      *
-     * @return \core_analytics\predictor
+     * @return \core_analytics\predictor[]
      */
     public static function get_all_prediction_processors() {
 

diff --git a/analytics/classes/model.php b/analytics/classes/model.php
@@ -145,7 +145,6 @@ public function is_available() {
         if (!$target) {
             return false;
         }
-        $analyser = $this->get_target();
 
         $classname = $target->get_analyser_class();
         if (!class_exists($classname)) {
@@ -296,7 +295,7 @@ protected function init_analyser($options = array()) {
 
         $classname = $target->get_analyser_class();
         if (!class_exists($classname)) {
-            throw \coding_exception($classname . ' class does not exists');
+            throw new \coding_exception($classname . ' class does not exists');
         }
 
         // Returns a \core_analytics\local\analyser\base class.