Skip to content

Commit

Permalink
MDL-73201 lang: Use fixed strings in the tests, too
Browse files Browse the repository at this point in the history
  • Loading branch information
mudrd8mz committed Dec 9, 2021
1 parent 558b4c8 commit 46e2e20
Show file tree
Hide file tree
Showing 16 changed files with 47 additions and 47 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ Feature: Enable Block Completion in a course using activity completion
And I follow "View all submissions"
And I click on "Grade" "link" in the "Student" "table_row"
And I set the field "Grade out of 100" to "53"
And I set the field "Notify students" to "0"
And I set the field "Notify student" to "0"
And I press "Save changes"
And I am on "Course 1" course homepage with editing mode on
And I add the "Course completion status" block
Expand Down Expand Up @@ -115,7 +115,7 @@ Feature: Enable Block Completion in a course using activity completion
And I follow "View all submissions"
And I click on "Grade" "link" in the "Student" "table_row"
And I set the field "Grade out of 100" to "49"
And I set the field "Notify students" to "0"
And I set the field "Notify student" to "0"
And I press "Save changes"
And I am on "Course 1" course homepage with editing mode on
And I add the "Course completion status" block
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Feature: Course summary block used on the frontpage
And I am on site homepage
And I turn editing mode on
And I add the "Course/site summary" block
And I navigate to "Front page > Front page settings" in site administration
And I navigate to "Site home > Site home settings" in site administration
And I set the following fields to these values:
| summary | Proved the summary block works! |
And I press "Save changes"
Expand Down
2 changes: 1 addition & 1 deletion blocks/site_main_menu/tests/behat/add_url.feature
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ Feature: Add URL to main menu block
And I add the "Main menu" block
And I configure the "Main menu" block
And I set the following fields to these values:
| Page contexts | Display on the front page and any pages added to the front page |
| Page contexts | Display on the site home and any pages added to the site home. |
And I press "Save changes"
And I add a "URL" to section "0" and I fill the form with:
| Name | reference link |
Expand Down
20 changes: 10 additions & 10 deletions course/tests/behat/course_download_content_cm.feature
Original file line number Diff line number Diff line change
Expand Up @@ -29,30 +29,30 @@ Feature: Activities content download can be controlled
| downloadcoursecontentallowed | 1 |
And I log out

Scenario: "Include in course downloads (if that feature is enabled)" field default is set to "Yes" if nothing has been set
Scenario: "Include in course content download" field default is set to "Yes" if nothing has been set
Given I am on the Page1 "Page Activity editing" page logged in as admin
Then the field "Include in course downloads (if that feature is enabled)" matches value "Yes"
Then the field "Include in course content download" matches value "Yes"

Scenario: "Include in course downloads (if that feature is enabled)" field is not visible if course content is disabled on site level
Scenario: "Include in course content download" field is not visible if course content is disabled on site level
Given I log in as "admin"
And the following config values are set as admin:
| downloadcoursecontentallowed | 0 |
And I am on the Page1 "Page Activity editing" page
Then "Include in course downloads (if that feature is enabled)" "select" should not exist
Then "Include in course content download" "select" should not exist

Scenario: "Include in course downloads (if that feature is enabled)" field is visible even if course content is disabled on course level
Scenario: "Include in course content download" field is visible even if course content is disabled on course level
Given I log in as "admin"
And I am on "Course 1" course homepage
And I navigate to "Settings" in current page administration
When I set the field "Enable download course content" to "No"
And I press "Save and display"
And I am on the Page1 "Page Activity editing" page
Then "Include in course downloads (if that feature is enabled)" "select" should exist
Then "Include in course content download" "select" should exist

Scenario: "Include in course downloads (if that feature is enabled)" field should be visible but not editable for users without configuredownloadcontent capability
Scenario: "Include in course content download" field should be visible but not editable for users without configuredownloadcontent capability
Given I log in as "manager1"
And I am on the Folder1 "Folder Activity editing" page
And "Include in course downloads (if that feature is enabled)" "field" should exist
And "Include in course content download" "field" should exist
And I log out
And I log in as "admin"
When I set the following system permissions of "Manager" role:
Expand All @@ -61,6 +61,6 @@ Feature: Activities content download can be controlled
And I log out
And I log in as "manager1"
And I am on the Folder1 "Folder Activity editing" page
Then I should see "Include in course downloads (if that feature is enabled)"
Then I should see "Include in course content download"
And I should see "No"
And "Include in course downloads (if that feature is enabled)" "select" should not exist
And "Include in course content download" "select" should not exist
6 changes: 3 additions & 3 deletions course/tests/behat/frontpage_display_modes.feature
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@core @core_course
Feature: Front page displays items in different modes
Feature: Site home displays items in different modes
In order to show a clean and clear list of the site categories and course
As an admin
I need to set different frontpage display modes
Expand Down Expand Up @@ -27,7 +27,7 @@ Feature: Front page displays items in different modes
@javascript
Scenario: Displays a list of categories
When I set the following administration settings values:
| Front page items when logged in | List of categories |
| Site home items when logged in | List of categories |
| Maximum category depth | 2 |
And I am on site homepage
Then I should see "Category A" in the "region-main" "region"
Expand All @@ -43,7 +43,7 @@ Feature: Front page displays items in different modes
@javascript
Scenario: Displays a combo list
When I set the following administration settings values:
| Front page items when logged in | Combo list |
| Site home items when logged in | Combo list |
| Maximum category depth | 2 |
And I am on site homepage
Then I should see "Category A" in the "region-main" "region"
Expand Down
2 changes: 1 addition & 1 deletion course/tests/behat/frontpage_topic_section.feature
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@core @core_course
Feature: Front page topic section
Feature: Site home topic section
In order to show a display activities in the frontpage
As an admin
I need to edit the frontpage topic section
Expand Down
2 changes: 1 addition & 1 deletion mod/assign/tests/behat/assign_activity_completion.feature
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ Feature: View activity completion in the assignment activity
And I follow "View all submissions"
And I click on "Grade" "link" in the "Vinnie Student1" "table_row"
And I set the field "Grade out of 100" to "33"
And I set the field "Notify students" to "0"
And I set the field "Notify student" to "0"
And I press "Save changes"
And I follow "View all submissions"
And I log out
Expand Down
8 changes: 4 additions & 4 deletions mod/assign/tests/behat/bulk_release_anon_submissions.feature
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Feature: Bulk released grades should not be sent to gradebook while submissions
And I set the field "Grade out of 100" to "50"
And I set the field "Marking workflow state" to "In review"
And I set the field "Feedback comments" to "Great job!"
And I set the field "Notify students" to "0"
And I set the field "Notify student" to "0"
And I press "Save changes"
And I am on the "Test assignment name" "assign activity" page
And I follow "View all submissions"
Expand All @@ -66,7 +66,7 @@ Feature: Bulk released grades should not be sent to gradebook while submissions
And I set the field "Grade out of 100" to "50"
And I set the field "Marking workflow state" to "In review"
And I set the field "Feedback comments" to "Great job!"
And I set the field "Notify students" to "0"
And I set the field "Notify student" to "0"
And I press "Save changes"
And I am on the "Test assignment name" "assign activity" page
And I follow "View all submissions"
Expand All @@ -81,7 +81,7 @@ Feature: Bulk released grades should not be sent to gradebook while submissions
Then I should not see "Student 1 ([email protected])"
And I should not see "Student 2 ([email protected])"
And I set the field "Marking workflow state" to "Released"
And I set the field "Notify students" to "No"
And I set the field "Notify student" to "No"
And I press "Save changes"
And I am on the "Test assignment name" "assign activity" page
And I follow "View all submissions"
Expand Down Expand Up @@ -129,7 +129,7 @@ Feature: Bulk released grades should not be sent to gradebook while submissions
Then I should see "Student 1 ([email protected])"
And I should see "Student 2 ([email protected])"
And I set the field "Marking workflow state" to "Released"
And I set the field "Notify students" to "No"
And I set the field "Notify student" to "No"
And I press "Save changes"
And I am on the "Test assignment name" "assign activity" page
And I follow "View all submissions"
Expand Down
4 changes: 2 additions & 2 deletions mod/assign/tests/behat/display_grade.feature
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Feature: Check that the assignment grade can be updated correctly
Then I follow "View all submissions"
And I click on "Grade" "link" in the "Student 1" "table_row"
And I set the field "Grade out of 100" to "50"
And I set the field "Notify students" to "0"
And I set the field "Notify student" to "0"
And I press "Save changes"
And I follow "View all submissions"
And "Student 1" row "Grade" column of "generaltable" table should contain "50.00"
Expand Down Expand Up @@ -65,7 +65,7 @@ Feature: Check that the assignment grade can be updated correctly
When I follow "View all submissions"
And I click on "Grade" "link" in the "Student 1" "table_row"
And I set the field "Grade out of 100" to "50"
And I set the field "Notify students" to "0"
And I set the field "Notify student" to "0"
And I press "Save changes"
And I follow "View all submissions"
Then "Student 1" row "Grade" column of "generaltable" table should contain "50.00"
2 changes: 1 addition & 1 deletion mod/assign/tests/behat/filter_by_marker.feature
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Feature: In an assignment, teachers can filter displayed submissions by assigned
And I follow "View all submissions"
And I click on "Grade" "link" in the "Student 1" "table_row"
And I set the field "allocatedmarker" to "Marker 1"
And I set the field "Notify students" to "0"
And I set the field "Notify student" to "0"
And I press "Save changes"
And I click on "Edit settings" "link"

Expand Down
4 changes: 2 additions & 2 deletions mod/assign/tests/behat/grading_app_filters.feature
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Feature: In an assignment, teachers can change filters in the grading app
And I should not see "Test assignment name &"
And I set the field "allocatedmarker" to "Marker 1"
And I set the field "workflowstate" to "In marking"
And I set the field "Notify students" to "0"
And I set the field "Notify student" to "0"
And I press "Save changes"

And I am on the "Test assignment name &" Activity page
Expand All @@ -62,7 +62,7 @@ Feature: In an assignment, teachers can change filters in the grading app
And I click on "Grade" "link" in the "Student 1" "table_row"
And I set the field "allocatedmarker" to "Marker 1"
And I set the field "workflowstate" to "In marking"
And I set the field "Notify students" to "0"
And I set the field "Notify student" to "0"
And I press "Save changes"

And I am on the "Test assignment name &" Activity page
Expand Down
4 changes: 2 additions & 2 deletions mod/assign/tests/behat/grading_status.feature
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Feature: View the grading status of an assignment
And I set the field "Grade out of 100" to "50"
And I set the field "Marking workflow state" to "In review"
And I set the field "Feedback comments" to "Great job! Lol, not really."
And I set the field "Notify students" to "0"
And I set the field "Notify student" to "0"
And I press "Save changes"
And I am on the "Test assignment name" "assign activity" page
And I follow "View all submissions"
Expand Down Expand Up @@ -80,7 +80,7 @@ Feature: View the grading status of an assignment
And I click on "Grade" "link" in the "Student 1" "table_row"
And I should see "1 of 1"
And I set the field "Marking workflow state" to "In marking"
And I set the field "Notify students" to "0"
And I set the field "Notify student" to "0"
And I press "Save changes"
And I am on the "Test assignment name" "assign activity" page
And I follow "View all submissions"
Expand Down
6 changes: 3 additions & 3 deletions mod/assign/tests/behat/steps_blind_marking.feature
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Feature: Assignments correctly add feedback to the grade report when workflow an
And I set the field "Grade out of 100" to "50"
And I set the field "Marking workflow state" to "In review"
And I set the field "Feedback comments" to "Great job! Lol, not really."
And I set the field "Notify students" to "0"
And I set the field "Notify student" to "0"
And I press "Save changes"
And I follow "View all submissions"
And I should see "In review" in the "I'm the student's first submission" "table_row"
Expand All @@ -49,7 +49,7 @@ Feature: Assignments correctly add feedback to the grade report when workflow an
Scenario: Student identities are revealed after releasing the grades.
When I click on "Grade" "link" in the "I'm the student's first submission" "table_row"
And I set the field "Marking workflow state" to "Ready for release"
And I set the field "Notify students" to "0"
And I set the field "Notify student" to "0"
And I press "Save changes"
And I follow "View all submissions"
And I should see "Ready for release" in the "I'm the student's first submission" "table_row"
Expand All @@ -71,7 +71,7 @@ Feature: Assignments correctly add feedback to the grade report when workflow an
Scenario: Student identities are revealed before releasing the grades.
When I click on "Grade" "link" in the "I'm the student's first submission" "table_row"
And I set the field "Marking workflow state" to "Ready for release"
And I set the field "Notify students" to "0"
And I set the field "Notify student" to "0"
And I press "Save changes"
And I follow "View all submissions"
And I should see "Ready for release" in the "I'm the student's first submission" "table_row"
Expand Down
2 changes: 1 addition & 1 deletion mod/feedback/tests/behat/anonymous.feature
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ Feature: Anonymous feedback
@javascript
Scenario: Complete anonymous feedback and view analysis on the front page as an authenticated user
And I log in as "admin"
And I set the following system permissions of "Authenticated user on frontpage" role:
And I set the following system permissions of "Authenticated user on site home" role:
| capability | permission |
| mod/feedback:viewanalysepage | Allow |
And I log out
Expand Down
2 changes: 1 addition & 1 deletion mod/feedback/tests/behat/non_anonymous.feature
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ Feature: Non anonymous feedback
@javascript
Scenario: Complete non anonymous feedback and view analysis on the front page as an authenticated user
And I log in as "admin"
And I set the following system permissions of "Authenticated user on frontpage" role:
And I set the following system permissions of "Authenticated user on site home" role:
| capability | permission |
| mod/feedback:viewanalysepage | Allow |
And I log out
Expand Down
24 changes: 12 additions & 12 deletions question/bank/statistics/tests/behat/statistics_values.feature
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,12 @@ Feature: Show statistics in question bank
And I select "Questions" from the "questionbankactionselect" singleselect
When I navigate to "Question bank" in current page administration
And I select "Questions" from the "questionbankactionselect" singleselect
And I should see "likely" in the "TF1" "table_row"
And I should see "unlikely" in the "TF2" "table_row"
And I should see "unlikely" in the "TF3" "table_row"
And I should see "likely" in the "TF4" "table_row"
And I should see "likely" in the ".alert-warning" "css_element"
And I should see "unlikely" in the ".alert-success" "css_element"
And I should see "Likely" in the "TF1" "table_row"
And I should see "Unlikely" in the "TF2" "table_row"
And I should see "Unlikely" in the "TF3" "table_row"
And I should see "Likely" in the "TF4" "table_row"
And I should see "Likely" in the ".alert-warning" "css_element"
And I should see "Unlikely" in the ".alert-success" "css_element"

Scenario: View discrimination index in question bank, bad questions
Given user "student1" has attempted "Quiz 2" with responses:
Expand All @@ -134,9 +134,9 @@ Feature: Show statistics in question bank
When I am on the "Course 1" course page logged in as admin
When I navigate to "Question bank" in current page administration
And I select "Questions" from the "questionbankactionselect" singleselect
And I should see "likely" in the "TF1" "table_row"
And I should see "very likely" in the "TF2" "table_row"
And I should see "very likely" in the "TF3" "table_row"
And I should see "likely" in the "TF4" "table_row"
And I should see "very likely" in the ".alert-danger" "css_element"
And I should see "likely" in the ".alert-warning" "css_element"
And I should see "Likely" in the "TF1" "table_row"
And I should see "Very likely" in the "TF2" "table_row"
And I should see "Very likely" in the "TF3" "table_row"
And I should see "Likely" in the "TF4" "table_row"
And I should see "Very likely" in the ".alert-danger" "css_element"
And I should see "Likely" in the ".alert-warning" "css_element"

0 comments on commit 46e2e20

Please sign in to comment.