Merge pull request ARMmbed#12983 from kjbracey-arm/mutexcount

Mutex::unlock - decrement _count inside lock
create-msugi · Jun 4, 2020 · 0a365b3 · 0a365b3
2 parents ab43962 + b52a3b3
commit 0a365b3
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/rtos/source/Mutex.cpp b/rtos/source/Mutex.cpp
@@ -123,10 +123,12 @@ bool Mutex::trylock_until(Kernel::Clock::time_point abs_time)
 
 void Mutex::unlock()
 {
+    // Count must be adjusted inside the lock. This would leave it incorrect
+    // on failure, but it only is used for an assert in ConditionVariable,
+    // and a mutex release failure means MBED_ERROR anyway.
+    _count--;
+
     osStatus status = osMutexRelease(_id);
-    if (osOK == status) {
-        _count--;
-    }
 
     if (status != osOK && !mbed_get_error_in_progress()) {
         MBED_ERROR1(MBED_MAKE_ERROR(MBED_MODULE_KERNEL, MBED_ERROR_CODE_MUTEX_UNLOCK_FAILED), "Mutex unlock failed", status);