fix: not watch page files (umijs#1580)

crecreek · Dec 7, 2018 · a8909e3 · a8909e3
1 parent 8e728ae
commit a8909e3
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 1 deletion.
diff --git a/examples/func-test/src/pages/_mock.js b/examples/func-test/src/pages/_mock.js
@@ -0,0 +1,3 @@
+export default {
+  'GET /api/test': { code: 'ok' },
+};
diff --git a/packages/umi-build-dev/src/FilesGenerator.js b/packages/umi-build-dev/src/FilesGenerator.js
@@ -14,6 +14,8 @@ import { EXT_LIST } from './constants';
 
 const debug = require('debug')('umi:FilesGenerator');
 
+export const watcherIgnoreRegExp = /(^|[\/\\])(_mock.js$|\..)/;
+
 export default class FilesGenerator {
   constructor(opts) {
     Object.keys(opts).forEach(key => {
@@ -36,7 +38,7 @@ export default class FilesGenerator {
 
   createWatcher(path) {
     const watcher = chokidar.watch(path, {
-      ignored: /(^|[\/\\])(_mock.js$)|(\..)/, // ignore .dotfiles and _mock.js
+      ignored: watcherIgnoreRegExp, // ignore .dotfiles and _mock.js
       ignoreInitial: true,
     });
     watcher.on(

diff --git a/packages/umi-build-dev/src/FilesGenerator.test.js b/packages/umi-build-dev/src/FilesGenerator.test.js
@@ -0,0 +1,26 @@
+import { watcherIgnoreRegExp } from './FilesGenerator';
+
+describe('FilesGenerator', () => {
+  it('watcherIgnoreRegExp', () => {
+    expect(
+      watcherIgnoreRegExp.test(
+        '/Users/use/code/ant/umi2/examples/func-test/src/pages/test3.js',
+      ),
+    ).toBe(false);
+    expect(
+      watcherIgnoreRegExp.test(
+        '/Users/use/code/ant/umi2/examples/func-test/src/pages/_mock.js',
+      ),
+    ).toBe(true);
+    expect(
+      watcherIgnoreRegExp.test(
+        '/Users/use/code/ant/umi2/examples/func-test/src/pages/.umi/test.js',
+      ),
+    ).toBe(true);
+    expect(
+      watcherIgnoreRegExp.test(
+        '/Users/use/code/ant/umi2/examples/func-test/src/pages/.gitignore',
+      ),
+    ).toBe(true);
+  });
+});