Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed common layout #21

Merged
merged 3 commits into from
Sep 15, 2016
Merged

Fixed common layout #21

merged 3 commits into from
Sep 15, 2016

Conversation

skazi0
Copy link
Member

@skazi0 skazi0 commented Aug 31, 2016

Fixed common layout:

  • full height steps sidebar
  • bottom margin in details part

Based on Solution1 from: http://stackoverflow.com/questions/19695784/how-can-i-make-bootstrap-columns-all-the-same-height

Note: the height of the whole box is not fixed so it's going to change depending on the contents of the details section which might or might not be in line with the expectations. TBD.

@skazi0
Copy link
Member Author

skazi0 commented Sep 1, 2016

This is how it looks like in firefox:
zrzut ekranu z 2016-09-01 12-07-16

And this is on a narrow screen:
zrzut ekranu z 2016-09-01 12-08-10

@bisht-richa
Copy link
Contributor

Looks good.

@rsalevsky
Copy link
Member

Can you make first letter from the first commit capital?

@santiph santiph changed the title fixed common layout Fixed common layout Sep 14, 2016
@skazi0 skazi0 force-pushed the layout-fix branch 2 times, most recently from f146a20 to 5a1629d Compare September 14, 2016 09:52
@skazi0
Copy link
Member Author

skazi0 commented Sep 14, 2016

Updated commit message.

@santiph
Copy link
Contributor

santiph commented Sep 15, 2016

Approved

@santiph santiph merged commit 25d0722 into crowbar:master Sep 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants