Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better control bar #116

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Better control bar #116

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6eb75ea
Move ControlBar to separate component
darnfish May 30, 2020
d7c5525
Remove the loading indicator
darnfish May 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove the loading indicator 
Buttons that require REST-ful actions already have the rainbow loading animation
  • Loading branch information
@darnfish
darnfish committed May 30, 2020
commit d7c5525240001b53b7d3d9d17d2bb89d510b6291
1 change: 0 additions & 1 deletion nuxt.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ export default {
...script
]
},
loadingIndicator: '~/components/Loading/index.html',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you get to dislike that loading indicator?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put reasoning in the commit description

Screenshot 2020-05-30 at 01 49 07

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the page that's shown before the whole app loads, so it should be kept.

robots: {
// by default, this only allows the root to be indexed, not the rest, which is enough.
UserAgent: '*',
Expand Down