adds .data, fixes --checkdir #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzidane
reviewed
Sep 29, 2017
setup.py
Outdated
| @@ -60,5 +60,5 @@ class CustomInstall(install): | |||
| "console_scripts": ["check50=check50:main"] | |||
| }, | |||
| url="https://github.com/cs50/check50", | |||
| version="2.0.6" | |||
| version="2.0.8" | |||
There was a problem hiding this comment.
Actually, let's wait before merging, couple other changes pending it seems. And we should go to 2.1.0 anyway.
Adds segmentation fault detection, other bugfixes
Fixed EOF messages
Added SIGINT handler
|
Okay, ready for you, @kzidane! |
cmlsharp
reviewed
Sep 29, 2017
check50.py
Outdated
| @@ -67,6 +67,8 @@ def main(): | |||
| help="display the full tracebacks of any errors") | |||
|
|
|||
| config.args = parser.parse_args() | |||
| if isinstance(config.args.checkdir, list): | |||
There was a problem hiding this comment.
Since the nargs=1 line was removed, how could this ever be a list?
cmlsharp
suggested changes
Sep 29, 2017
There was a problem hiding this comment.
cs50/submit50#147 (EDIT: 147 was merged into develop, cs50/submit50#148 now needs to be merged into master) needs to be merged first. (setup.py requires submit50>=2.4.5 b/c the ability to customize submit50's cancel message is now required.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.