Check GitHub for exclude files #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmalan
requested changes
Jul 30, 2017
submit50.py
Outdated
| # separate branch into problem slug and source repo | ||
| branch = branch.rstrip("@cs50/checks") | ||
| try: | ||
| slug, src = branch.split("@", 1) |
There was a problem hiding this comment.
Was an old version, not required anymore. Fixed.
| url = "https://cs50.me/excludes/{}/".format(branch) | ||
|
|
||
| # separate branch into problem slug and source repo | ||
| branch = branch.rstrip("@cs50/checks") |
There was a problem hiding this comment.
Is it necessary to strip this off, if it was, for whatever reason, explicitly mentioned?
There was a problem hiding this comment.
Yeah, it's necessary so that students don't end up with some of their submissions on cs50/2017/x/greedy and some of them on cs50/2017/x/greedy@cs50/checks, for example. Best to keep all submissions for the same problem in one predetermined branch.
locale/es/LC_MESSAGES/messages.po
Outdated
| msgid "Submitted {}! See https://cs50.me/submissions/{}." | ||
| msgstr "¡Se entregó {}! Puedes ver https://cs50.me/submissions/{}." | ||
| msgid "Submitted {}! See https://cs50.me/submissions." | ||
| msgstr "¡Se entregó {}! Puedes ver https://cs50.me/submissions/." |
submit50.py
Outdated
| @@ -418,9 +418,17 @@ def submit(org, problem): | |||
| if problem.split("/")[0].isdigit(): | |||
There was a problem hiding this comment.
What if problem.split returns []?
There was a problem hiding this comment.
This will go away, actually, per the other PR.
|
@dmalan, updated per your comments! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.