Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

included message catalog #135

Merged
merged 1 commit into from
Sep 29, 2017
Merged

included message catalog #135

merged 1 commit into from
Sep 29, 2017

Conversation

kzidane
Copy link
Member

@kzidane kzidane commented Aug 8, 2017

Solves #94.

$ pip install -U .
...
Successfully installed requests-2.18.3 submit50-2.4.1
$ locale-gen es_ES.UTF-8
Generating locales...
  es_ES.UTF-8... done
Generation complete.
$ export LANGUAGE=es_ES.UTF-8
$ submit50 cs50/2017/x/hello
Connecting.......
Parece que faltan estos archivos:
 hello.c
Asegúrate de tener los archivos necesarios antes de entregar.
$ export LANGUAGE=en_US
$ submit50 cs50/2017/x/hello
Connecting.....
You seem to be missing these files:
 hello.c
Ensure you have the required files before submitting.
$ find / -type f -name messages.mo
/opt/pyenv/versions/3.6.0/submit50/locale/es/LC_MESSAGES/messages.mo

@kzidane
Copy link
Member Author

kzidane commented Aug 21, 2017

@dmalan any takes on this one before merging in?

@dmalan
Copy link
Member

dmalan commented Sep 18, 2017

Oops, sorry for missing this. Do we not currently compile the .po to .mo upon build?

@kzidane
Copy link
Member Author

kzidane commented Sep 18, 2017

No worries. Just rebased. Nope, but we should be doing that once this is merged if you don't have any takes.

@dmalan dmalan merged commit b442ec5 into develop Sep 29, 2017
@dmalan dmalan deleted the locale branch September 29, 2017 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants