Skip to content

Commit

Permalink
cifs: remove unnecessary dentry_unhash on rmdir/rename_dir
Browse files Browse the repository at this point in the history
Cifs has no problems with lingering references to unlinked directory
inodes.

CC: Steve French <[email protected]>
CC: [email protected]
Signed-off-by: Sage Weil <[email protected]>
Signed-off-by: Al Viro <[email protected]>
  • Loading branch information
liewegas authored and Al Viro committed May 26, 2011
1 parent 7ca5736 commit b6ff24a
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions fs/cifs/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -1461,8 +1461,6 @@ int cifs_rmdir(struct inode *inode, struct dentry *direntry)

cFYI(1, "cifs_rmdir, inode = 0x%p", inode);

dentry_unhash(direntry);

xid = GetXid();

full_path = build_path_from_dentry(direntry);
Expand Down Expand Up @@ -1571,9 +1569,6 @@ int cifs_rename(struct inode *source_dir, struct dentry *source_dentry,
FILE_UNIX_BASIC_INFO *info_buf_target;
int xid, rc, tmprc;

if (target_dentry->d_inode && S_ISDIR(target_dentry->d_inode->i_mode))
dentry_unhash(target_dentry);

cifs_sb = CIFS_SB(source_dir->i_sb);
tlink = cifs_sb_tlink(cifs_sb);
if (IS_ERR(tlink))
Expand Down

0 comments on commit b6ff24a

Please sign in to comment.