hwmon: (lm85) Fix error paths in probe function

We must remove all files we created, even in error cases. Fixes second part of kernel bug #34072: https://bugzilla.kernel.org/show_bug.cgi?id=34072 Signed-off-by: Jean Delvare <[email protected]> Acked-by: Guenter Roeck <[email protected]>
csanz · Apr 29, 2011 · bc4d45f · bc4d45f
1 parent 5f441e2
commit bc4d45f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/drivers/hwmon/lm85.c b/drivers/hwmon/lm85.c
@@ -1331,11 +1331,11 @@ static int lm85_probe(struct i2c_client *client,
 	if (data->type != emc6d103s) {
 		err = sysfs_create_group(&client->dev.kobj, &lm85_group_minctl);
 		if (err)
-			goto err_kfree;
+			goto err_remove_files;
 		err = sysfs_create_group(&client->dev.kobj,
 					 &lm85_group_temp_off);
 		if (err)
-			goto err_kfree;
+			goto err_remove_files;
 	}
 
 	/* The ADT7463/68 have an optional VRM 10 mode where pin 21 is used