Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cmdline args to set maker and taker fees #921

Merged
merged 1 commit into from
Apr 15, 2019
Merged

add cmdline args to set maker and taker fees #921

merged 1 commit into from
Apr 15, 2019

Conversation

xloem
Copy link
Contributor

@xloem xloem commented Apr 6, 2019

Helps to let users adjust fees when the binary lib hasn't integrated fee changes yet.

@ctubio ctubio mentioned this pull request Apr 15, 2019
Closed
@ctubio ctubio merged commit f0d6a67 into ctubio:master Apr 15, 2019
@xloem
Copy link
Contributor Author

xloem commented Apr 15, 2019

@ctubio thanks for merging this !

Note that it lies about "takeFee" being unused. This is actually used instead of the make fee at the moment. #922 changes it to "makeFee" and then the documentation in this PR is correct.

@ctubio
Copy link
Owner

ctubio commented Apr 15, 2019

thanks for the comment will keep in mind (but i already knew so noworry :D), i didnt fully understood yet #922 but will do very soOn'¡ :D thanks again for your time''

@xloem xloem deleted the customfees branch April 17, 2019 10:24
@ctubio
Copy link
Owner

ctubio commented Apr 20, 2019 •
edited
Loading

quick link to related issue: #926
quick link to related issue: #898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
💝 improvement ✔️ acknowledged 🏥 in the lab
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xloem @ctubio