Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve #944 #954

Merged
merged 2 commits into from
Jun 30, 2019
Merged

Solve #944 #954

merged 2 commits into from
Jun 30, 2019

Conversation

nonkreon
Copy link
Contributor

This seems to be working

@coveralls
Copy link

Coverage Status

Coverage remained the same at 40.787% when pulling 40a6a0e on nonkreon:master into c336285 on ctubio:master.

@ctubio
Copy link
Owner

ctubio commented Jun 28, 2019

🐨 added quick link: #944

many thanks for your time'' lemme try to merge soOn''

@nonkreon
Copy link
Contributor Author

added quick link: #944

yeah I'ma git rookie I don't know how to properly link and commit and so on 😆
I gotta tell you though

targetPositionAutoPercentage = ((1 + max(-1.0, min(1.0, targetPosition))) / 2) * 1e+2;
may be performing redundant operations now, can be simplified but I didn't want to disturb your code too much

@ctubio
Copy link
Owner

ctubio commented Jun 30, 2019

will check on next commitz the redundancy of

targetPositionAutoPercentage = ((1 + max(-1.0, min(1.0, targetPosition))) / 2) * 1e+2;

many thanks for your time'¡'''

🐨 mergiiin''¡ seems all super OK

@ctubio ctubio merged commit 40a6a0e into ctubio:master Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants