Skip to content

Commit

Permalink
Add prometheus metric for canary/bench (cadence-workflow#4625)
Browse files Browse the repository at this point in the history
  • Loading branch information
longquanzheng authored Nov 12, 2021
1 parent 2e75c15 commit e2adab9
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 2 deletions.
3 changes: 2 additions & 1 deletion bench/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ bench:
cadence:
service: "cadence-frontend" # frontend service name
host: "127.0.0.1:7933" # frontend address
#metrics: ... # optional detailed client side metrics like workflow latency
```
- **Metrics**: metrics configuration. Similar to server metric emitter, only M3/Statsd/Prometheus is supported.
- **Log**: logging configuration. Similar to server logging configuration.
Expand Down Expand Up @@ -207,4 +208,4 @@ When all tests complete, `Cron` will update the value of the `Passed` search att
A sample cron configuration is in `config/bench/cron.json`, and it can be started with
```
cadence --do <domain> wf start --tl cadence-bench-tl-0 --wt cron-test-workflow --dt 30 --et 7200 --if config/bench/cron.json
```
```
3 changes: 2 additions & 1 deletion canary/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ cadence:
service: "cadence-frontend" # frontend service name
address: "127.0.0.1:7833" # frontend address
#host: "127.0.0.1:7933" # replace address with host if using Thrift for compatibility
#metrics: ... # optional detailed client side metrics like workflow latency. But for monitoring, simply use server side metrics `workflow_success` is enough.
```
- **Metrics**: metrics configuration. Similar to server metric emitter, only M3/Statsd/Prometheus is supported.
- **Log**: logging configuration. Similar to server logging configuration.
Expand Down Expand Up @@ -263,4 +264,4 @@ Batch workflow tests the batch job feature. Make sure advanced visibility featur
To manually start one run of this test case:
```
cadence --do <> workflow start --tl canary-task-queue --et 10 --wt workflow.batch -i 0
```
```
5 changes: 5 additions & 0 deletions config/bench/development.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,8 @@ bench:
cadence:
service: "cadence-frontend"
host: "127.0.0.1:7933"
metrics:
statsd: ~
prometheus:
timerType: "histogram"
listenAddress: "127.0.0.1:8004"
5 changes: 5 additions & 0 deletions config/canary/development.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,8 @@ cadence:
service: "cadence-frontend"
address: "127.0.0.1:7833"
#host: "127.0.0.1:7933" # replace address with host if using Thrift for compatibility
metrics:
statsd: ~
prometheus:
timerType: "histogram"
listenAddress: "127.0.0.1:8005"

0 comments on commit e2adab9

Please sign in to comment.