Mini challenge 1 / Daniel Castro #10
Conversation
| @@ -1,38 +1,25 @@ | |||
| import React, { useLayoutEffect } from 'react'; | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
very nice work with components!
| import styled from 'styled-components'; | ||
| import { MdAccountCircle } from 'react-icons/md'; | ||
|
|
||
| export const AvatarIcon = styled(MdAccountCircle)` |
There was a problem hiding this comment.
Cool, it is nice to use this icon library 👍
| <CardContainer> | ||
| <CardImgWrapper to={`/video/${videoId}`}> | ||
| <CardImg alt={`${title} | Image Video`} src={imgSrc} /> | ||
| </CardImgWrapper> | ||
| <CardTitle>{title}</CardTitle> | ||
| <CardDescription> | ||
| {description} | ||
| <span>#{channel}</span> | ||
| <span>{publishedDate}</span> | ||
| </CardDescription> | ||
| </CardContainer> |
There was a problem hiding this comment.
I like this component hirarchy!
|
|
||
| function CardList() { | ||
| return ( | ||
| <CardGrid> |
There was a problem hiding this comment.
Very nice use of styles for responsive view
| @@ -0,0 +1,34 @@ | |||
| import { createGlobalStyle } from 'styled-components'; | |||
|
|
|||
| export const GlobalStyle = createGlobalStyle` | |||
There was a problem hiding this comment.
I liked so much this approach, I learned something new!
Review (Mini challenge 1)Nice job Daniel! You're doing a great job here, I found your work very clean, well-arranged, you made great use of components, styled components, theme, and global styles, congrats and keep it like that! Acceptance Criteria (Mini challenge 1)
Bonus Points (Mini challenge 1)
|
No description provided.