Skip to content

Commit

Permalink
Fix test failure when run from DNS hijacked ISP
Browse files Browse the repository at this point in the history
Removes the tld from 'unreachable host' to circumvent DNS hijacking
ISPs returning a 200 response for non-existent domains.

Fixes elastic#7124
  • Loading branch information
robbavey committed May 16, 2017
1 parent 90432f5 commit 06823be
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
context "when the remote host is unreachable" do
it "returns false and yield a debug message" do
# To make sure we really try to connect to a failing host we have to let it through webmock
host ="#{Time.now.to_i.to_s}-do-not-exist.com"
host ="#{Time.now.to_i.to_s}-do-not-exist"
WebMock.disable_net_connect!(:allow => host)
ENV["LOGSTASH_PACK_URL"] = "http://#{host}"
expect(subject.get_installer_for(plugin_name)).to be_falsey
Expand Down

0 comments on commit 06823be

Please sign in to comment.