Skip to content

Commit

Permalink
Run offline specs separately from online ones.
Browse files Browse the repository at this point in the history
The internet disabling C hack can break other tests, so, we now run
those tests separately.

Fixes elastic#7178

Fixes elastic#7179
  • Loading branch information
andrewvc committed May 22, 2017
1 parent 412dd7b commit bb60eb8
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
8 changes: 7 additions & 1 deletion ci/travis_integration_run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,10 @@ fi

echo "Running integration tests from qa/integration directory"
cd qa/integration
rspec

# The offline specs can break the online ones
# due to some sideeffects of the seccomp policy interfering with
# the docker daemon
# See prepare_offline_pack_spec.rb for details
rspec --tag ~offline
rspec --tag offline
8 changes: 7 additions & 1 deletion qa/integration/specs/cli/prepare_offline_pack_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,13 @@
require_relative "../../framework/helpers"
require "logstash/devutils/rspec/spec_helper"

describe "CLI > logstash-plugin prepare-offline-pack" do

# These are segmented into a separate tag that MUST be run separately from any docker tests
# The reason they break the Docker API and that in turn even breaks tests not using Docker
# is that the Docker API has a global singleton Docker container set up as soon as it's
# required that acts in the background and will err out if the internet is down
# See https://github.com/elastic/logstash/issues/7160#issue-229902725
describe "CLI > logstash-plugin prepare-offline-pack", :offline => true do
before(:all) do
@fixture = Fixture.new(__FILE__)
@logstash_plugin = @fixture.get_service("logstash").plugin_cli
Expand Down

0 comments on commit bb60eb8

Please sign in to comment.