Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set/reset the world modified flag and 'DEF' fields #6686

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

MNikoliCC
Copy link
Contributor

@MNikoliCC MNikoliCC commented Oct 24, 2024

Description
All modified 'DEF' fields are reset to their initial values when the simulation is reset. The world modified flag is only set when the simulation time is 0 and there is a change between any of the initial and modified values in the 'DEF' fields.

Related Issues
Fixes #5225

Tasks

  • 'DEF' fields are reset to their initial values when the simulation is reset.
  • The world modified flag is set at appropriate time

…eir initial values when the simulation is reset. The world modified flag is only set when the simulation time is 0 and there is a change between any of the initial and modified values in the'DEF' fields.
@MNikoliCC MNikoliCC requested a review from a team as a code owner October 24, 2024 17:21
@omichel omichel marked this pull request as draft October 24, 2024 18:36
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source code tests are failing.
Can you fix them?

@MNikoliCC MNikoliCC changed the title Fix issue #5225 Set/reset the world modified flag and 'DEF' fields Oct 24, 2024
worldCheckTimer->start(500);
}

void WbNodeEditor::tryConnectToWorld() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot have a timer here, we need a cleaner solution

…ew Signal When The 'world' Instance Is Created
@MNikoliCC MNikoliCC marked this pull request as ready for review October 29, 2024 08:14
@lukicdarkoo lukicdarkoo added bug Something isn't working test distribution Start the distribution test test suite Start the test suite test webots build Start the build tests test worlds Start the worlds test labels Nov 11, 2024
Copy link
Member

@lukicdarkoo lukicdarkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to find a simpler and more generic solution (to cover not only DEF but other fields as well). Let's pause on this until we figure out a better solution

@lukicdarkoo lukicdarkoo marked this pull request as draft December 5, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test distribution Start the distribution test test suite Start the test suite test webots build Start the build tests test worlds Start the worlds test
Development

Successfully merging this pull request may close these issues.

World not flagged as modified after reset
3 participants