-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set/reset the world modified flag and 'DEF' fields #6686
base: master
Are you sure you want to change the base?
Conversation
…eir initial values when the simulation is reset. The world modified flag is only set when the simulation time is 0 and there is a change between any of the initial and modified values in the'DEF' fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source code tests are failing.
Can you fix them?
worldCheckTimer->start(500); | ||
} | ||
|
||
void WbNodeEditor::tryConnectToWorld() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot have a timer here, we need a cleaner solution
…ew Signal When The 'world' Instance Is Created
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to find a simpler and more generic solution (to cover not only DEF but other fields as well). Let's pause on this until we figure out a better solution
Description
All modified 'DEF' fields are reset to their initial values when the simulation is reset. The world modified flag is only set when the simulation time is 0 and there is a change between any of the initial and modified values in the 'DEF' fields.
Related Issues
Fixes #5225
Tasks