-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add job timings vs cycle point visualisation #1510
Conversation
LGTM. I like the mini chart. At the moment I think it's reasonable to have this in the analysis view, but we can always spin it off if desired. It might be nice to display the mean times in the chart. |
bce34d2
to
8bd4c5f
Compare
How's this going? Looked close when I last dropped by. |
e0847d0
to
86a9954
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JAllen42, @ChrisPaulBennett - looks like there's one error and three minor suggestions left to sort out, but close. We are starting to get close to 8.3.0 release so the time window for getting this merged is now drawing in. Would be great to get this in with the 8.3.0 release where we can announce it along with other new features. |
I'll second that, it'd be awesome to get this into 8.3.0. |
Co-authored-by: Ronnie Dutta <[email protected]>
Co-authored-by: Ronnie Dutta <[email protected]>
Looks like a bug in vue-apexcharts actually: apexcharts/vue-apexcharts#318 |
Ok, suggest overlooking this issue for the purpose of review, we can rebuild when a fix is released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately the refresh button isn't doing anything
I've had a look at this with Chris, and it looks like it is (mostly) working as intended to us. When you have some tasks plotted from a running workflow and you press the refresh button it will add to the plot the times from any cycle points that have been run since the query was last run. We have spotted one issue though. The options for the drop down list of tasks are passed to the component as a prop from the analysis view. This means if completely new tasks have been run, these will not be added to the list when the refresh button is pressed. They will only be shown when the analysis view is closed and reopened, or the refresh button from either the table or box and whiskers pressed. Would this explain what you saw? Either way, it looks like a test could be added for this |
Yes that's the issue I am getting |
Fix e2e tests Co-authored-by: Ronnie Dutta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could do with tidying up common code to TimeSeries.vue
and Analysis.vue
later on
🎉 |
Partially addresses #1170
Linked to cylc/cylc-uiserver#530
This is a prototype for a view for visualising job timing information as a function of cycle point. It uses the UI server branch from cylc/cylc-uiserver#530 to get historic job timings.
Tasks can be added to the graph one by one (hopefully to prevent overcrowding for complex workflows), with a mini chart at the bottom to control the x-axis zooming (though how this works should be made more obvious). You can hover to see timing and platform information.
At the moment I have added in to the analysis view, but this could be split into its own view if preferred - the shape of the data is different, which means there are different options for how much is kept in memory when switching between visualisations, and when to re-query the database. It might depend what other ways of visualising similar data might be added?
Currently I've called this a time series visualisations, other suggestions are welcome along with any other comments!
Outstanding work includes:
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.towncrier create 1510.feat.md
)?.?.x
branch.