Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP-698: remove resolution #1209

Merged
merged 2 commits into from
Oct 29, 2021
Merged

Conversation

geektortoise
Copy link
Contributor

No description provided.

@geektortoise geektortoise self-assigned this Oct 25, 2021
@geektortoise
Copy link
Contributor Author

@loic911
Ok except for

  • grails-app/services/be/cytomine/image/AbstractImageService.groovy. Too much logs (log.info("10"), log.info("Image=$images" ) )
  • grails-app/services/be/cytomine/utils/DataTablesService.groovy resolution is deleted but there is no physicalSize equivalent. Instead of deleting the resolution, change it for PhysicalSizeX

@loic911
Copy link
Contributor

loic911 commented Oct 27, 2021

Is datatables (DataTablesService) still useful? I can't see any usage of datatables parameter ?

@geektortoise
Copy link
Contributor Author

I see one call here

responseSuccess(dataTablesService.process(params, ImageInstance, where, fieldFormat,project))

@loic911
Copy link
Contributor

loic911 commented Oct 28, 2021

Yep, but I mean is the params.datatables still useful ? ;-) I can't see any usage of datatables parameter in the frontend nor in the js client.
I think it's a legacy from the previous jquery frontend and the datatables dependency (https://datatables.net/)

@geektortoise geektortoise merged commit 409dc20 into release-3.2.x Oct 29, 2021
@geektortoise
Copy link
Contributor Author

Thanks

@geektortoise
Copy link
Contributor Author

I will set a @deprecated for Datatable service

@geektortoise geektortoise deleted the OP-698-remove-resolution branch October 29, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants