Skip to content

Commit

Permalink
Merge pull request yadm-dev#431 from signed-log/makefile-oci-patch
Browse files Browse the repository at this point in the history
  • Loading branch information
TheLocehiliosan committed Aug 27, 2022
2 parents 6304553 + 075cd1b commit a89e5ce
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 8 deletions.
5 changes: 5 additions & 0 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,11 @@ these principles when making changes.
```text
$ make test
```
If you don't use `docker` but an OCI engine akin to `podman`, you can set it through the `OCI` switch for every target
```text
$ make test OCI=podman
```
5. Create a feature branch, based off the `develop` branch.
Expand Down
17 changes: 9 additions & 8 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
PYTESTS = $(wildcard test/test_*.py)
IMAGE = yadm/testbed:2022-01-07
IMAGE = docker.io/yadm/testbed:2022-01-07
OCI = docker

.PHONY: all
all:
Expand Down Expand Up @@ -94,7 +95,7 @@ test:
py.test -v $(testargs); \
else \
$(MAKE) -s require-docker && \
docker run \
$(OCI) run \
--rm -t$(shell test -t 0 && echo i) \
-v "$(CURDIR):/yadm:ro" \
$(IMAGE) \
Expand All @@ -117,7 +118,7 @@ test:
.PHONY: testhost
testhost: require-docker .testyadm
@echo "Starting testhost"
@docker run \
@$(OCI) run \
-w /root \
--hostname testhost \
--rm -it \
Expand All @@ -129,7 +130,7 @@ testhost: require-docker .testyadm
scripthost: require-docker .testyadm
@echo "Starting scripthost \(recording script\)"
@printf '' > script.gz
@docker run \
@$(OCI) run \
-w /root \
--hostname scripthost \
--rm -it \
Expand Down Expand Up @@ -159,7 +160,7 @@ testenv:

.PHONY: image
image:
@docker build -f test/Dockerfile . -t "$(IMAGE)"
@$(OCI) build -f test/Dockerfile . -t "$(IMAGE)"


.PHONY: man
Expand Down Expand Up @@ -204,11 +205,11 @@ install:

.PHONY: sync-clock
sync-clock:
docker run --rm --privileged alpine hwclock -s
$(OCI) run --rm --privileged alpine hwclock -s

.PHONY: require-docker
require-docker:
@if ! command -v "docker" > /dev/null 2>&1; then \
echo "Sorry, this make target requires docker to be installed."; \
@if ! command -v $(OCI) > /dev/null 2>&1; then \
echo "Sorry, this make target requires docker to be installed, to use another docker-compatible engine, like podman, re-run the make command adding OCI=podman"; \
false; \
fi

0 comments on commit a89e5ce

Please sign in to comment.