[cloud_firestore] Fix wrong FieldValue (firebase#1543)

* [cloud_firestore] Fix wrong FieldValue * Update integration test to catch increment
czenpai · Apr 29, 2019 · 06643a1 · 06643a1
1 parent 1551096
commit 06643a1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...ndroid/src/main/java/io/flutter/plugins/firebase/cloudfirestore/CloudFirestorePlugin.java b/...ndroid/src/main/java/io/flutter/plugins/firebase/cloudfirestore/CloudFirestorePlugin.java
@@ -654,8 +654,8 @@ final class FirestoreMessageCodec extends StandardMessageCodec {
   private static final byte DELETE = (byte) 134;
   private static final byte SERVER_TIMESTAMP = (byte) 135;
   private static final byte TIMESTAMP = (byte) 136;
-  private static final byte INCREMENT_INTEGER = (byte) 137;
-  private static final byte INCREMENT_DOUBLE = (byte) 138;
+  private static final byte INCREMENT_DOUBLE = (byte) 137;
+  private static final byte INCREMENT_INTEGER = (byte) 138;
 
   @Override
   protected void writeValue(ByteArrayOutputStream stream, Object value) {

diff --git a/packages/cloud_firestore/example/test_driver/cloud_firestore.dart b/packages/cloud_firestore/example/test_driver/cloud_firestore.dart
@@ -54,10 +54,10 @@ void main() {
       snapshot = await ref.get();
       expect(snapshot.data['message'], 2);
       await ref.updateData(<String, dynamic>{
-        'message': FieldValue.increment(40.0),
+        'message': FieldValue.increment(40.1),
       });
       snapshot = await ref.get();
-      expect(snapshot.data['message'], 42.0);
+      expect(snapshot.data['message'], 42.1);
       await ref.delete();
     });